Page MenuHomeWildfire Games

Don't detect audio card when audio is disabled
Needs ReviewPublic

Authored by Stan on Thu, Jun 11, 6:35 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Test Plan

Build the game with CONFIG2_AUDIO disabled and check if there are any warnings left and check for completnesss

Event Timeline

Stan created this revision.Thu, Jun 11, 6:35 PM

Is this in response to a specific bug?

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/soundmanager/scripting/JSInterface_Sound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/Util.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2399/display/redirect

Stan added a subscriber: linkmauve.Thu, Jun 11, 6:47 PM

Nah it's extracted from a patch @linkmauve made for the Meson build system. It looked like a reasonable change so I made a diff for it. :)

vladislavbelov added inline comments.
source/ps/Util.cpp
147

Maybe compiled without instead of disabled? Because disabled sounds more like muted.

Stan updated this revision to Diff 12276.Fri, Jun 12, 11:36 PM
Stan marked an inline comment as done.

Fix notes

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2415/display/redirect