The art/actors/kushites/pyramid.xml file is identical to the pyramid_large.xml file (except for two unnecessary lines) and the difference between simulation/templates/structures/pyramid.xml and pyramid_large.xml is that the former has the cost of the pyramid_small.xml, otherwise they're the same, but since it's not buildable nor used in any maps, this is irrelevant.
Because there is no point in maintaining duplicate files, this patch deletes that unused actor and template.
It's a bit surprising nobody noticed before.
Details
Details
- Reviewers
Stan - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23833: Delete duplicate kush_pyramid actor
Check for completeness.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2422/display/redirect
Comment Actions
It was actually rendered that way in rP21180. The goal was for the pyramid to switch between the small and big variants somehow I guess I never implemented it correctly. Probably could use Phenotype to do this, although I guess footprints and obstruction would be incorrect.
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2638/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2639/display/redirect
Comment Actions
You're welcome, if you run checkrefs.pl --check-map-xml it should tell you. Currently missing files don't break the build, so you won't be notified directly by the CI, however checkrefs is ran there, so you can see the logs by cliking on the Linux jenkins link (when it works :P)
Of course I guess good old grep works too :)