Paths

Table of Contentst

Differential D2820

[gui] replace hyphen-minus with em-dash in credits
ClosedPublic
Actions

Authored by Nescio on Jun 15 2020, 5:16 PM.

Details

Reviewers

Imarok

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23870: [gui] replace hyphen-minus with em-dash in credits

Summary

This patch replaces the hyphen-minus ("-") that separates the nick and name entries when displaying the credits with an em-dash ("—"), which is longer and therefore looks better in this case. For comparison:
hyphen-minus (currently):

en-dash (another possibility):

em-dash (this proposal):

Test Plan

Trivial change, agree it is visibly an improvement.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jun 15 2020, 5:16 PM

Owners added a subscriber: Restricted Owners Package.Jun 15 2020, 5:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2440/display/redirect

Harbormaster completed remote builds in B12116: Diff 12326.Jun 15 2020, 5:26 PM

Nescio edited reviewers, added: Restricted Owners Package; removed: Restricted Owners Package.Jul 2 2020, 9:41 PM

Nescio mentioned this in D2895: x → × in game speeds.Jul 22 2020, 6:01 PM

Looks good

This revision is now accepted and ready to land.Jul 22 2020, 6:09 PM

Closed by commit rP23870: [gui] replace hyphen-minus with em-dash in credits (authored by Imarok). · Explain WhyJul 22 2020, 6:24 PM

This revision was automatically updated to reflect the committed changes.

Imarok added a commit: rP23870: [gui] replace hyphen-minus with em-dash in credits.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

credits/

credits.js

2 lines

Diff 12859

View Options

ps/trunk/binaries/data/mods/public/gui/credits/credits.js

[gui] replace hyphen-minus with em-dash in creditsClosedPublicActions