Differential D2831

Remove redundant bonus schema from DeathDamage.js.
ClosedPublic
Actions

Authored by Freagarach on Jun 22 2020, 7:25 PM.

Details

Reviewers

Commits

rP23785: Remove unused bonuses schema from deathDamage

Test Plan

Verify it was indeed unused after rP22754.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Jun 22 2020, 7:25 PM

No reference to bonusesSchema in svn

Attack.js already had this treatment
front doesn't fall

This revision is now accepted and ready to land.Jun 22 2020, 10:11 PM

This revision was landed with ongoing or failed builds.Jun 22 2020, 10:12 PM

Closed by commit rP23785: Remove unused bonuses schema from deathDamage (authored by bb). · Explain Why

This revision was automatically updated to reflect the committed changes.

bb added a commit: rP23785: Remove unused bonuses schema from deathDamage.

Thanks for the review and commit @bb :)

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

DeathDamage.js

31 lines

Diff 12428

View Options

ps/trunk/binaries/data/mods/public/simulation/components/DeathDamage.js

Remove redundant bonus schema from DeathDamage.js.ClosedPublicActions