Page MenuHomeWildfire Games

Add where and how to contribute to README.txt
ClosedPublic

Authored by Imarok on Jun 23 2020, 8:09 PM.

Details

Summary

Add where and how to contribute to README.txt
Especially for people visiting the github mirror that increases the chance that they get it right.
(Patch also contains some wording by Stan)

Test Plan

Read through the text and look for errors.
Agree with the approach.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Jun 23 2020, 8:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2512/display/redirect

Freagarach added inline comments.
README.txt
55 ↗(On Diff #12438)

+https://

Imarok updated this revision to Diff 12440.Jun 23 2020, 10:15 PM
Imarok marked an inline comment as done.

https

Imarok added inline comments.Jun 23 2020, 10:16 PM
README.txt
55 ↗(On Diff #12438)

Thx

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2514/display/redirect

bb added a subscriber: bb.Jun 23 2020, 10:43 PM

This works only for contributing code right? Not sure if many artist, translators and others will read this file, but maybe good to include those too.

README.txt
55 ↗(On Diff #12440)

Should sentences end with a period? or does that mess up the URL?

Imarok added inline comments.Jun 23 2020, 10:45 PM
README.txt
55 ↗(On Diff #12440)

I guess so. And it's consistent with the rest of the file. (not puttong periods)

bb added inline comments.Jun 23 2020, 10:59 PM
README.txt
55 ↗(On Diff #12440)

What about:

------------------
 Contributing Code
 -----------------

If you want to help out programming for the game, have a look at 
https://trac.wildfiregames.com/wiki/GettingStartedProgrammers
or contact us on #0ad-dev on irc.quakenet.org

--------------------
Contributing Artwork
--------------------

If you want to make artwork for the game, have a look at 
https://trac.wildfiregames.com/#Forartists:
or visit the forums http://www.wildfiregames.com/forum/
-----------
Translating
-----------

You can help translating the game at ​https://www.transifex.com/projects/p/0ad/ 
for more information, see https://trac.wildfiregames.com/wiki/Localization

It's not really consistent in the rest of the file ;)

Imarok marked an inline comment as done.Jun 24 2020, 11:20 PM

It's not really consistent in the rest of the file ;)

What?

The rest of the file is not consistent in its use of periods. Or it is: use one after each sentence but not when the sentence ends with a link or command of some kind.

wraitii accepted this revision.Jun 28 2020, 2:50 PM
wraitii added a subscriber: wraitii.

I agree with the intention, I don't care very much about periods, I like @bb's suggestion, I'd suggest you commit this whenever you feel like it :)

This revision is now accepted and ready to land.Jun 28 2020, 2:50 PM
This revision was automatically updated to reflect the committed changes.