Paths

Table of Contentst

When opening the summary as Gaia don't show warnings
ClosedPublic
Actions

Authored by Imarok on Jun 25 2020, 12:35 AM.

Details

Reviewers

bb
Silier

Commits

rP23841: Fix opening the summary as Gaia

Trac Tickets

#5782

Summary

Instead show the observer summary. (Shows all players)

Test Plan

Start a game (singleplayer or with cheats).
Do Alt+D and enable Change perspective.
In the top bar change to Gaia.
Open the summary.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Jun 25 2020, 12:35 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2521/display/redirect

Stan awarded a token.Jun 25 2020, 12:41 AM

Harbormaster completed remote builds in B12224: Diff 12452.Jun 25 2020, 1:01 AM

Can't we show GAIA kills and such?

Gaia does not have statistics tracker

Works fine and is complete.

This revision is now accepted and ready to land.Jul 12 2020, 11:45 AM

In D2836#121560, @Freagarach wrote:

Can't we show GAIA kills and such?

As Angen said.

If you think it makes sense, please create a ticket ;)

Closed by commit rP23841: Fix opening the summary as Gaia (authored by Imarok). · Explain WhyJul 16 2020, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Imarok added a commit: rP23841: Fix opening the summary as Gaia.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

MenuButtons.js

2 lines

Diff 12729

View Options

ps/trunk/binaries/data/mods/public/gui/session/MenuButtons.js

When opening the summary as Gaia don't show warningsClosedPublicActions