Details
- Reviewers
Freagarach - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23957: Remove some unnecessary lines from a few civic structure templates.
Check for mistakes.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 12776 Build 24906: Vulcan Build Jenkins Build 24905: Vulcan Build (macOS) Jenkins Build 24904: Vulcan Build (Windows) Jenkins Build 24903: arc lint + arc unit
Event Timeline
binaries/data/mods/public/simulation/templates/structures/cart_tophet.xml | ||
---|---|---|
4 | Already defined in parent. | |
15 | idem | |
37–39 | idem | |
binaries/data/mods/public/simulation/templates/structures/rome_temple_vesta.xml | ||
2 | Does not really take any values defined in rome_temple, therefore unnecessary parent step. | |
binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre_military_colony.xml | ||
51–53 | This structure gets a territory root from its parent, therefore it is immune to territory decay. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2557/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2558/display/redirect
binaries/data/mods/public/simulation/templates/structures/rome_temple_vesta.xml | ||
---|---|---|
2 | Well, it takes the civ and more importantly, the production queue. |
binaries/data/mods/public/simulation/templates/structures/rome_temple_vesta.xml | ||
---|---|---|
2 | Production queue, good point! |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2906/display/redirect
binaries/data/mods/public/simulation/templates/structures/rome_temple_vesta.xml | ||
---|---|---|
2 | Not really for the civ line, but for the production queue change. Such that also mars has the vision tech, but that may be changing balance. |
binaries/data/mods/public/simulation/templates/structures/rome_temple_vesta.xml | ||
---|---|---|
2 | rome_temple_mars.xml is not buildable, therefore its production queue does not affect gameplay balance. |
Grmbl, I added a dot again after the diff. Can you close this one also please, @Nescio?