Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2589/display/redirect

mul_round should work too.

See D268 and rP22003 for history and the controversy.

To make it simple what it does is the following

Operation -> To Integer -> ToCharacterString()
ex: 300 * 1.1 -> 330 -> "330"

Operation -> ToCharacterString()
ex: 300 * 1.1 -> "330.0000"

Note that @wraitii forgot to update checkrefs.pl too. Might be obsoleted by the Python conversion of the script.

Not sure about the performance impact of using techs.

@Nescio i can remove elephant loot of D2816, and keep only 300?

Not sure about the performance impact of using techs.

Technologies are global and permanent and don't really affect performance (see also advanced and elite technologies). Auras are temporary and local, so having too many of them could have an impact.

@Nescio i can remove elephant loot of D2816, and keep only 300?

Yes.

They are however applied everytime something changes, (eg, if you change some stats of any units) While I believe template changes are not, but it's likely irrelevant yes.

If it were noticeable we wouldn't have technologies. Or civ bonuses. Or ranks.

In D2864#122827, @Nescio wrote:

If it were noticeable we wouldn't have technologies. Or civ bonuses. Or ranks.

Sure. Ranks change the templates :)

Can we actually see the tooltip somewhere? If not that means useless translation work.

The tooltip is there for consistency (and in case someone makes it automatically displayable in the future; cf. civ bonus files).

Patch makes it work as expected (as in not breaking templates and keeping the default values) works no matter the civ (even gaia). My last concern is that if it might influence people into using more decimals which will lead to issues with rounding in the looting component (using mul_round doesn't have this issue)

Well, I suppose loot is supposed to be an integer, but then again, see advanced and elite technologies:

		{ "value": "Loot/food", "multiply": 1.2 },
		{ "value": "Loot/wood", "multiply": 1.2 },
		{ "value": "Loot/stone", "multiply": 1.2 },
		{ "value": "Loot/metal", "multiply": 1.2 },
		{ "value": "Loot/xp", "multiply": 1.2 }

Yeah, I'm just being more careful this time, as I blindly trusted the previous patch, which I shouldn't have done.

Blind trust is rarely a good thing. Better be critical.

Sure. But if I can't trust the people doing the reviews i can't merge the balancing patches :)

Will give it another look tomorrow and commit it after that.