spart_champion_infantry_sword.xml costs +5 seconds, upgrade_rank_advanced_mercenary.json increases training time by 20%, upgrade_rank_elite_healer.json does not. This is not really consistent.
A much cleaner and more efficient approach is setting a training time modification instead in the Advanced and Elite technologies, which is much easier to maintain long term. This patch does that, of 20%, which means effectively no change for mercenaries and a negligible difference for the Skiritai (10 s × (1.2^2 - 1) = 4.4 s, instead of 5 s).
While at it, also properly order the modifications, rephrase the tooltip per the style guide, and rename them to unit_advanced.json and unit_elite.json, respectively.
See also D2685.
Details
Details
- Reviewers
borg- wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23818: Move train time increase for advanced/elite to the upgrade tech.
Check for mistakes.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2590/display/redirect
Comment Actions
Putting "Cost/BuildTime" on the "Rank Techs" seems to make more sense, besides being easier for future changes. Bassicaly no changes in gameplay.
Patch is also very useful for D2843.
Comment Actions
Seems OK.
I suppose 20% increased build time is a little cheap compared to how units currently upgrade :p but that's a separate topic.