Page MenuHomeWildfire Games

[gameplay] tweak upgrade_mace_silvershields tech.
ClosedPublic

Authored by borg- on Jul 8 2020, 2:50 AM.

Details

Summary

Discussed in D2846

Change research time to 60, like other similar techs.
Decrease the cost from 1000 to 600 metal. for just metal, 1000 is a completely excessive value.

See also D2868

Test Plan

Check mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

borg- created this revision.Jul 8 2020, 2:50 AM
Nescio added inline comments.Jul 8 2020, 11:09 AM
upgrade_mace_silvershields.json
5 ↗(On Diff #12586)

While at it, could you properly indent this?

	"requirements": {
		"all": [
			{ "tech": "phase_city" },
			{ "civ": "mace" }
		]
	},
borg- updated this revision to Diff 12609.Jul 9 2020, 1:10 AM

Correct identation pointed by @Nescio

Nescio accepted this revision.Jul 12 2020, 7:28 PM
This revision is now accepted and ready to land.Jul 12 2020, 7:28 PM

I can't opine on this, never used Macedonians much. Given there are no planned buffs for them as far as I can see, and they still look like an underpowered civilization, I have no objections.

Stan added a subscriber: Stan.Jul 14 2020, 8:48 PM

Nescio do you just agree with the syntax or with the change as well ? If the latter can you elaborate a bit on why?

Nescio do you just agree with the syntax or with the change as well ? If the latter can you elaborate a bit on why?

Clicking “Accept” means approving of everything a patch does.

  • I agree the current cost of 1000 metal is excessive and the proposed value of 600 is reasonable. 500 or 700 would have been acceptable too, but not e.g. 300, given the effect of this technology.
  • It makes sense that city phase technologies take longer to research than village phase technologies, therefore the research time increase from 40 to 60 is appropiate.
  • The tooltip string change is necessary because of rP23819.
Stan added a comment.Jul 15 2020, 10:56 AM

Thanks. It's better to have an explicit approval than a silent one. https://trac.wildfiregames.com/wiki/ReviewingPatches somewhat covers that but it's more for bugs and features, while this patch is not really either of those options.