Details
Check mistakes.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
upgrade_mace_silvershields.json | ||
---|---|---|
5 ↗ | (On Diff #12586) | While at it, could you properly indent this? "requirements": { "all": [ { "tech": "phase_city" }, { "civ": "mace" } ] }, |
I can't opine on this, never used Macedonians much. Given there are no planned buffs for them as far as I can see, and they still look like an underpowered civilization, I have no objections.
Nescio do you just agree with the syntax or with the change as well ? If the latter can you elaborate a bit on why?
Nescio do you just agree with the syntax or with the change as well ? If the latter can you elaborate a bit on why?
Clicking “Accept” means approving of everything a patch does.
- I agree the current cost of 1000 metal is excessive and the proposed value of 600 is reasonable. 500 or 700 would have been acceptable too, but not e.g. 300, given the effect of this technology.
- It makes sense that city phase technologies take longer to research than village phase technologies, therefore the research time increase from 40 to 60 is appropiate.
- The tooltip string change is necessary because of rP23819.
Thanks. It's better to have an explicit approval than a silent one. https://trac.wildfiregames.com/wiki/ReviewingPatches somewhat covers that but it's more for bugs and features, while this patch is not really either of those options.