Page MenuHomeWildfire Games

Fix rooting mistake in CGame::ReallyStartGame
ClosedPublic

Authored by Itms on Jul 9 2020, 7:55 PM.

Details

Summary

As detected by Bellaz89 in #5776, the GUI page global object is incorrectly rooted into the simulation context.

In my opinion, there is a tiny, tiny, microscopic chance, that this could cause the GC segfault in SpiderMonkey. In that hypothesis, the upgrade to 45 made the JS engine less permissive about this mistake. I can't reproduce the segfault, so I can't make sure.

In any case, this should be fixed.

Test Plan

Check the code correctness, maybe test if the segfault is still here.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Jul 9 2020, 7:55 PM
Vulcan added a comment.Jul 9 2020, 8:04 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2612/display/redirect

Angen awarded a token.Jul 10 2020, 1:24 PM
Bellaz89 accepted this revision.Jul 11 2020, 4:16 PM
This revision is now accepted and ready to land.Jul 11 2020, 4:16 PM