Page MenuHomeWildfire Games
Differential D2872

[gameplay] introduce mace infantry swordsman champion
ClosedPublic
Actions

Authored by Nescio on Jul 12 2020, 12:14 PM.

Details

Reviewers
wraitii
badosu
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23829: Give Macedonians a champion swordsman.
Summary

This patch is split off from D2863. It introduces a mace champion swordsman, using the black cloak actor, trainable at fortress and (with technology) barracks. This gives mace a much needed counter vs rams (athen has marines and spart skiritai).

The Thracian black cloak is historically justifiable as a Macedonian champion: Philip V of Macedon (r. 221–179 BC) had an elite unit of Thracians equipped with rhomphaia, black cloaks, and white shields, serving as a vanguard (Plutarch Aemilius Paulus 18.3).

Test Plan

Check for mistakes, agree this is an improvement.

Diff Detail

Event Timeline

Nescio created this revision.Jul 12 2020, 12:14 PM
Owners added a subscriber: Restricted Owners Package.Jul 12 2020, 12:14 PM
Nescio mentioned this in D2863: [gameplay] deprecate stoas and stoa champions.Jul 12 2020, 12:45 PM
Nescio edited the summary of this revision. (Show Details)Jul 12 2020, 12:52 PM
Vulcan added a comment.Jul 12 2020, 1:11 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2621/display/redirect

Harbormaster completed remote builds in B12365: Diff 12642.Jul 12 2020, 1:46 PM
wraitii added a comment.Jul 12 2020, 5:49 PM

I don't really agree with the Maiden change, there are other _maiden_ templates for Maurya and this makes it somewhat inconsistent. Adding two lines to the barracks templates seems rather ok.

Nescio updated this revision to Diff 12647.Jul 12 2020, 7:22 PM
Nescio edited the summary of this revision. (Show Details)
  • keep maiden as is
Vulcan added a comment.Jul 12 2020, 7:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2625/display/redirect

Harbormaster completed remote builds in B12370: Diff 12647.Jul 12 2020, 7:41 PM
badosu awarded a token.Jul 12 2020, 8:04 PM
badosu added a comment.Jul 12 2020, 8:07 PM

Just a nitpick, athenian marines are never used as anti-siege, sword cavalry is used often instead. Also, not all maps have water, most played don't.

borg- added a subscriber: borg-.Jul 13 2020, 3:06 PM

Macedonia really needs a unit like that, that's a nice addition.

borg- added a comment.EditedJul 13 2020, 3:12 PM
In D2872#123492, @badosu wrote:

Just a nitpick, athenian marines are never used as anti-siege, sword cavalry is used often instead. Also, not all maps have water, most played don't.

Would be interesting to be able to train marines in ginasium (not sure about historical precision).

Nescio added a comment.Jul 13 2020, 6:24 PM

@badosu, @borg-, others, if you approve of everything a differential does, feel free to click “Add Action...” → “Accept Revision”. That also applies elsewhere.

badosu accepted this revision.Jul 14 2020, 3:10 AM

Much appreciated!

This revision is now accepted and ready to land.Jul 14 2020, 3:10 AM
wraitii accepted this revision.EditedJul 14 2020, 9:47 AM

Thanks for this :)

Edit: you were missing a <SelectionGroupName>units/mace_champion_infantry_swordsman</SelectionGroupName>, fixed before merging.

Closed by commit rP23829: Give Macedonians a champion swordsman. (authored by wraitii). · Explain WhyJul 14 2020, 9:55 AM
This revision was automatically updated to reflect the committed changes.
wraitii added a commit: rP23829: Give Macedonians a champion swordsman..
Nescio added a comment.Jul 14 2020, 10:07 AM

Edit: you were missing a <SelectionGroupName>units/mace_champion_infantry_swordsman</SelectionGroupName>, fixed before merging.

Oops, apparently I'm quite sloppy when redoing patches, thanks for correcting.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
templates/
structures/
1 line
1 line
units/
13 lines
6 lines

Diff 12647

View Options

binaries/data/mods/public/simulation/templates/structures/mace_fortress.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_structure_military_barracks.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/units/mace_champion_infantry_swordsman.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/units/mace_champion_infantry_swordsman_barracks.xml

Loading...
Wildfire Games · Phabricator