Page MenuHomeWildfire Games

[maps] use merc_ instead of mace_ for stoa champions
ClosedPublic

Authored by Nescio on Jul 12 2020, 12:26 PM.

Details

Reviewers
wraitii
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23962: Use mercenaries in scenarios instead of mace_* duplicates.
Summary

This patch is split off from D2863. It makes scenarios use merc_thorakites.xml and merc_thureophoros.xml instead of their mace_ duplicates, as is already the case for merc_black_cloak.xml.

Test Plan

Check for completeness and correctness.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jul 12 2020, 12:26 PM
Owners added a subscriber: Restricted Owners Package.Jul 12 2020, 12:26 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2622/display/redirect

Unless I'm mistaken, you can also delete the mace_* templates?

Unless I'm mistaken, you can also delete the mace_* templates?

Yes, the {civ}_* derivatives ought to be deleted, but only after they're removed from the stoa production queue, which is done in D2863. This split off the map corrections to make D2863 more reviewable.

Freagarach accepted this revision.Aug 13 2020, 6:03 PM
Freagarach added a subscriber: Freagarach.
  • Useful (use mercenaries whenever possible).
  • Compleat (cannot be extended).
  • Correct (no errors).
This revision is now accepted and ready to land.Aug 13 2020, 6:03 PM
This revision was automatically updated to reflect the committed changes.