Page MenuHomeWildfire Games

Remove dead AI manager serializablePrototype code
Needs ReviewPublic

Authored by Itms on Mon, Jul 20, 5:43 PM.

Details

Reviewers
wraitii
Trac Tickets
#4893
Summary

The AI Manager had code to serialize/deserialize objects with a user-defined prototype. However, that code is not used.

The intent was to make it possible to serialize/deserialize custom object types, but D2746 offers a more general solution to this problem and it blocks the SM migration at the moment.

As such, it is deleted.

Test Plan

Validate that no code relies on this.

Event Timeline

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/CCmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2731/display/redirect

Itms added a subscriber: Itms.Mon, Jul 20, 5:55 PM

I believe that you can also delete the SetSerializablePrototypes and IsSerializablePrototypefrom the (de)serializer, as you don't replace them by anything. They were only called by this AI code.

Itms added a reviewer: Itms.Mon, Jul 20, 5:56 PM
Itms commandeered this revision.Sat, Aug 1, 7:19 PM
Itms updated this revision to Diff 12997.
Itms edited reviewers, added: wraitii; removed: Itms.

Update with the version from the SM52 git migration branch.

Itms updated the Trac tickets for this revision.Sat, Aug 1, 7:21 PM
Vulcan added a comment.Sat, Aug 1, 7:27 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2834/display/redirect