Page MenuHomeWildfire Games

Give the tool "pick.xml" into the right hand
ClosedPublic

Authored by Mr.lie on Jul 24 2020, 10:57 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23903: Fix the "pick" tool being in the incorrect hand.
Summary

Female Citizen gather ore, rock and ruins with the pick-tool in the wrong(left) hand instead the right hand. Also infantry on gather ruins.

Test Plan

Try all animations in Atlas-Editor to see that it works correct.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mr.lie created this revision.Jul 24 2020, 10:57 PM
asterix added reviewers: Stan, Restricted Owners Package.Jul 24 2020, 11:21 PM
asterix added a subscriber: asterix.

Thanks for your patch

Stan added a comment.Jul 25 2020, 3:31 PM

Under what name do you wish to be credited? Can either be like

{nick: "Mr.lie"}
{nick: "Mr.lie", name: "FirstName Middle Name Last Name"}
{nick: "Mr.lie", name: "FirstName Last Name"}
{nick: "Mr.lie", name: "FirstName L."}
Stan accepted this revision.Jul 25 2020, 3:34 PM

Patch works as expected. Will commit it when the crediting matter is settled.

This revision is now accepted and ready to land.Jul 25 2020, 3:34 PM
Mr.lie added a comment.EditedJul 25 2020, 3:39 PM
In D2903#125942, @Stan wrote:

Under what name do you wish to be credited? Can either be like

{nick: "Mr.lie"}
{nick: "Mr.lie", name: "FirstName Middle Name Last Name"}
{nick: "Mr.lie", name: "FirstName Last Name"}
{nick: "Mr.lie", name: "FirstName L."}

if so then {nick: "Mr.lie", name: "FirstName Last Name"}

Stan added a comment.Jul 25 2020, 3:42 PM

Is your Phabricator name correct ? Erhard Lipinski?

In D2903#125947, @Stan wrote:

Is your Phabricator name correct ? Erhard Lipinski?

Yes, it is. Thanks.

Stan added a comment.Jul 25 2020, 5:54 PM

Won't commit it today (AFK). I have an open question where should I credit, for it's not art per se, maybe programming?

This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Jul 27 2020, 9:35 AM
bb added a subscriber: bb.Jul 27 2020, 4:24 PM

This patch brings me to a question though: why we don't have left hand varied units?