Page MenuHomeWildfire Games

Deny to run the game with Fixed rendering pipeline
AcceptedPublic

Authored by vladislavbelov on Sat, Jul 25, 5:07 PM.

Details

Reviewers
asterix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#5791
Summary

Before removing the whole "fixed" pipeline we need to add an assertion. Because user have to know the game can't work.

Test Plan
  1. Apply the patch and compile the game
  2. Make sure that it works for ARB and GLSL pipelines

Event Timeline

vladislavbelov created this revision.Sat, Jul 25, 5:07 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2782/display/redirect

Stan added a subscriber: Stan.Sat, Jul 25, 5:20 PM
Stan added inline comments.
source/ps/GameSetup/GameSetup.cpp
1011

L" The game does not support pre-shader graphics cards."

1015

Exit, maybe? I have a feeling this will display the ugly popup nobody understands...

vladislavbelov added inline comments.Sat, Jul 25, 5:22 PM
source/ps/GameSetup/GameSetup.cpp
1015

Maybe, I just follow other exits from this function.

Stan added inline comments.Sat, Jul 25, 5:26 PM
source/ps/GameSetup/GameSetup.cpp
1007

So this will be removed but the check will stay after the complete removal, correct? So users won't be greated by nothing?

1015

Exception seems to not match the actuall error. Video Mode Failed would be weird, since the gui is displayed :D

I wholeheartedly agree with the intent here.
It might be better to exit from the GUI, and make the GUI message "more red" to inform the player better. Not sure, your call imo.

It might be better to exit from the GUI, and make the GUI message "more red" to inform the player better. Not sure, your call imo.

We can't do something in GUI, because we can't render our GUI without "fixed" pipeline for users who does support only "fixed" pipeline.

source/ps/GameSetup/GameSetup.cpp
1007

No, that won't be removed.

1015

No, GUI won't be displayed.

We can't do something in GUI, because we can't render our GUI without "fixed" pipeline for users who does support only "fixed" pipeline.

Ah, yes, such an obvious thing to miss :p
Welp, go ahead.

Stan added inline comments.Sat, Jul 25, 6:45 PM
source/ps/GameSetup/GameSetup.cpp
1007

So we will keep the fixed option forever even though there won't be any such option ?

asterix accepted this revision.Sat, Jul 25, 6:47 PM
asterix added a subscriber: asterix.

I think this is nice change and since above people also agree, I agree too but maybe more noble would be to in warning write that they need drivers with some version of graphics library and other supported shader pipelines. I cannot comment on code though.

This revision is now accepted and ready to land.Sat, Jul 25, 6:47 PM

I think this is nice change and since above people also agree, I agree too but maybe more noble would be to in warning write that they need drivers with some version of graphics library and other supported shader pipelines. I cannot comment on code though.

We had that warning for about 7 years. So I think current warning is enough.

source/ps/GameSetup/GameSetup.cpp
1007

Only option, not the code beside that. Because we have hwdetect which might switch rendering to "fixed" for some bugged GPU drivers.

Alright then.

No objection if it gets committed.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2816/display/redirect

Stan added a comment.Fri, Jul 31, 7:20 PM

New behavior seems better as the message is correct and the game actually exits anyway even if you press continue