This patch let horses move on the animation "carry_meat". Therefore added an animation named "carry_meat" to the relevant "base_horse_*"-variants similar to the "camelry-variants".**
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- Iterate through all unit actors in atlas (except heroes and champions because they doesn't gather meat) to see it works
- Start a game and let an cavalry actor gather meat to see it works without side-effects
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 12637 Build 24426: Vulcan Build Jenkins Build 24425: Vulcan Build (macOS) Jenkins Build 24424: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Currently in the atlas editor on the animation "carry_meat" the horses keep standing, they don't walk. The Camelry_archers walk on this animation
Comment Actions
With this patch all animations "approach_*", "carry_* and formations (anti_cavalry_*, phalanx_*, syntagma_*, testudo_*) are playable (i.e. combine walk + anim)
Delete also the basket from "female_gather_meat" because they do not use it.
Attach the back_basket on "approach_fruit" because he is used for carrying
Comment Actions
Interesting. But you need to add more animations in atlas for it to work right? Also none of those animations are actually used in the game :/ (They are used but differently) which means this patch adds a lot of maintenance work...
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2793/display/redirect
Comment Actions
No, the "lists.xml" is untouched. This patch only make the given animations playable for atlas.
Comment Actions
This is incorrect and adding duplication to art files.
Every animation you have added is never going to be used by simulation.
The names are names of variants, and animations are idle, walk, run and so on.
Reason why you do not see them to play in atlas is because it is not picked correct animation variant to play them.
Same applies for https://code.wildfiregames.com/rP23904.
There is bunch of animations in list, which actually should not be there, because they are only variants.
That is why I requested changes on https://code.wildfiregames.com/D2042. Hopefully, after that one is implemented we will be able to remove the ones which should not be there among animations.
Just for clarifications. Formation related variants were animations and that is why they are in atlas animation list, but they were rewritten as variants.