Page MenuHomeWildfire Games

[gui] split art credits
ClosedPublic

Authored by Nescio on Jul 27 2020, 10:16 AM.

Details

Summary

Currently the art.json credits file contains maps, art, and sound credits. This patch splits it into three, since these are three entirely different sets of files, involving different skills and workflows, and different people.
Lack of room is not an issue, here a screenshot on minimum resolution (1024×768):

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jul 27 2020, 10:16 AM
Owners added a subscriber: Restricted Owners Package.Jul 27 2020, 10:16 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2785/display/redirect

bb accepted this revision as: bb.Jul 27 2020, 5:10 PM
bb removed a reviewer: Restricted Owners Package.
bb added a subscriber: bb.
bb added inline comments.
binaries/data/mods/public/gui/credits/texts/audio.json
5 ↗(On Diff #12932)

Should be Audio lead no?

127–129 ↗(On Diff #12932)

some spaces while at it

This revision is now accepted and ready to land.Jul 27 2020, 5:10 PM
This revision was automatically updated to reflect the committed changes.