Page MenuHomeWildfire Games

Adds ARB shaders for GUI materials to replace fixed ones
ClosedPublic

Authored by vladislavbelov on Jul 30 2020, 10:49 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23945: Adds ARB shaders for GUI materials to replace fixed ones.
Trac Tickets
#5791
Summary

Allow to draw GUI materials without fixed and GLSL.

Test Plan
  1. Apply the patch
  2. Make sure that the game looks the same with and without GLSL (Prefer GLSL option)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2812/display/redirect

vladislavbelov retitled this revision from Adds ARB shaders for GUI materials to replace fixed once to Adds ARB shaders for GUI materials to replace fixed ones.Jul 31 2020, 5:31 AM
Stan added a subscriber: Stan.Jul 31 2020, 2:58 PM

Works fine for me in release and debug, Not sure why you changed the last file. ARB and GLSL show no difference.

In D2921#126612, @Stan wrote:

Not sure why you changed the last file.

I removed the unused variable for more clear comparison of ARB and GLSL shaders.

Stan added a comment.Aug 3 2020, 12:45 PM

Also works on my Intel UHD620

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2020, 10:32 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.