The global label "unsupported" may lead to duplicated symbols
when the function is inlined in multiple places. This may happen
in any case, but using LTO exposes this problem reliably.
Details
Details
- Reviewers
Itms
Builds successfully also with LTO on x86 (32bit) now
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
Hey there thanks for the patch! I believe you should report that to the upstream of premake :)
I believe @Itms has plans to allow the use of your distro provided premake :)
Comment Actions
Hi Stefan, thanks for this patch. Indeed, we are merely providing a bundled version of premake, and we try to keep it as close as possible from upstream.
If premake is patched and installed on your system, as Stan says, you can build 0 A.D. by calling update-workspaces.sh --with-system-premake5.
You should open this pull request at https://github.com/premake/premake-core/pulls. They are rather quick at reviewing and including changes. I have to warn you that maybe they will also prefer waiting for your fix to be included in mbedtls, so that they upgrade their copy of the lib.
Whenever your change is included and released in premake, feel free to post here and I will gladly upgrade premake to its latest release. In the meantime, I am closing this.