Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- unused-includes
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 12740 Build 24771: Vulcan Build Jenkins Build 24770: Vulcan Build (macOS) Jenkins Build 24769: Vulcan Build (Windows) Jenkins Build 24768: arc lint + arc unit
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2870/display/redirect
Comment Actions
Added string stream back. The remaining includes removed by the diff should no longer be used. iirc, these were what each was used for:
- GameSetup was used back when the revision D2199 included a definition of the scenario config in cpp which was used in the RLInterface. (At the time, it had a from static method which would convert from CLI args or protobuf - it was using GRPC at the beginning - to a GameConfig object.)
- tuple was replaced with the Command struct for storing player IDs and the command
- queue was used back when it was using a channel for synchronization across the threads rather than mutexes
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2871/display/redirect