Page MenuHomeWildfire Games

Fixes and improvements to the CI pipelines
ClosedPublic

Authored by Itms on Aug 4 2020, 6:17 PM.

Details

Summary

Currently the cppcheck run is broken in coala due to upstream issue https://github.com/coala/coala-bears/issues/2450 (which doesn't get much traction).

I am patching the coala docker image manually, and adapting the coafile accordingly.

I use the opportunity to delete a now unused script, and to move a folder to a more appropriate location.

I also include here a lot of needed improvements.

Test Plan

Run on Jenkins.

Event Timeline

Itms created this revision.Aug 4 2020, 6:17 PM
Vulcan added a comment.Aug 4 2020, 6:18 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/2334/display/redirect

Vulcan added a comment.Aug 4 2020, 6:42 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1235/display/redirect

Vulcan added a comment.Aug 4 2020, 7:20 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2872/display/redirect

Itms requested review of this revision.Aug 4 2020, 7:20 PM
Itms updated this revision to Diff 13051.Aug 4 2020, 7:34 PM

Move files in a way that arcanist understands.

Vulcan added a comment.Aug 4 2020, 7:42 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2873/display/redirect

Itms updated this revision to Diff 13055.Aug 4 2020, 11:46 PM

Correct dockerfile.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2876/display/redirect

Vulcan added a comment.Aug 5 2020, 3:30 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2887/display/redirect

Itms updated this revision to Diff 13074.Aug 5 2020, 3:41 PM

Address coala warnings.

Vulcan added a comment.Aug 5 2020, 4:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2890/display/redirect

Vulcan added a comment.Aug 5 2020, 4:47 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2894/display/redirect

wraitii added a subscriber: wraitii.Aug 6 2020, 3:52 PM
wraitii added inline comments.
build/jenkins/dockerfiles/coala.Dockerfile
19

On a sidenote, it might be a better idea to put this fork in 0ad/ so that you're not the only one that can update it.

Itms updated this revision to Diff 13109.Aug 6 2020, 4:28 PM

Fix on Python 3.8 (sent upstream https://github.com/coala/coala-bears/pull/2976)
Fix caching in a docker container (not sent yet)
Display file name of cppcheck results

This is now activated on Jenkins for all differentials.

Vulcan added a comment.Aug 6 2020, 4:31 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2921/display/redirect

Stan added a subscriber: Stan.Aug 6 2020, 4:37 PM
Stan added inline comments.
.coafile
7

Typo?

Vulcan added a comment.Aug 6 2020, 4:39 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2922/display/redirect

Itms updated this revision to Diff 13110.Aug 6 2020, 4:41 PM

Obviously.

Vulcan added a comment.Aug 6 2020, 4:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2923/display/redirect

Itms updated this revision to Diff 13114.Aug 6 2020, 6:06 PM

Adapt LicenseYearBear to the current version of the python package svn.

Vulcan added a comment.Aug 6 2020, 6:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2928/display/redirect

Vulcan requested changes to this revision.Aug 10 2020, 7:30 AM

Build was aborted.

builderr-debug-gcc6.txt
builderr-release-gcc6.txt

Link to build: https://jenkins.wildfiregames.com/job/tests/36/display/redirect

This revision now requires changes to proceed.Aug 10 2020, 7:30 AM
Itms updated this revision to Diff 13158.Aug 10 2020, 10:43 AM
Itms retitled this revision from Fix cppcheck in coala to Fixes and improvements to the CI pipelines.
Itms edited the summary of this revision. (Show Details)

Slight fixes.
Post build warnings as Phabricator comments, so that they are not missed in case of a successful build.
Post lint as inline comments.

Itms removed a reviewer: Vulcan.Aug 10 2020, 2:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 18 2020, 2:47 PM
This revision was automatically updated to reflect the committed changes.