Page MenuHomeWildfire Games

Removes old matrices from sky rendering
ClosedPublic

Authored by vladislavbelov on Aug 9 2020, 1:51 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23952: Removes old matrices from sky rendering in shader path.
Summary

gl*Matrix are deprecated in new GL version and use fixed pipeline. We need to avoid that for shaders for the easier fixed > shader transition.

Test Plan
  1. Apply the patch and compile the game
  2. Make sure that skies look the same (with and without "Prefer GLSL" option)
  3. Make sure that skies are rotating in Atlas by changing sun rotation

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Aug 9 2020, 1:51 AM
Vulcan added a comment.Aug 9 2020, 2:04 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2951/display/redirect

vladislavbelov requested review of this revision.Aug 9 2020, 2:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2020, 1:25 PM
This revision was automatically updated to reflect the committed changes.