Differential D2944

Completely separates fixed and shader paths in sky rendering
ClosedPublic
Actions

Authored by vladislavbelov on Aug 9 2020, 3:42 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23954: Completely separates fixed and shader paths in sky rendering.

Summary

Removes usages of fixed pipeline functions in shader path.

Test Plan

Apply the patch and compile the game
Make sure that skies look the same with and without "Prefer GLSL" option

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Aug 9 2020, 3:42 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2954/display/redirect

Harbormaster completed remote builds in B12837: Diff 13152.Aug 9 2020, 4:02 PM

vladislavbelov requested review of this revision.Aug 9 2020, 4:02 PM

Fixes my issue on Intel with GLSL on
Before:

After

This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2020, 5:21 PM

Closed by commit rP23954: Completely separates fixed and shader paths in sky rendering. (authored by vladislavbelov). · Explain Why

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP23954: Completely separates fixed and shader paths in sky rendering..

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

renderer/

SkyManager.cpp

147 lines

Diff 13153

View Options

ps/trunk/source/renderer/SkyManager.cpp

Completely separates fixed and shader paths in sky renderingClosedPublicActions