Disable the WordPopulation checkbox for scenarios.
ClosedPublic
Actions

Authored by Freagarach on Aug 14 2020, 9:48 AM.

Details

Reviewers

Commits

rP23995: Disable WorldPopulation option for scenarios.

Summary

As noted by @Angen, the checkbox for WorldPopulation ought to be disabled for a scenario (after rP23873).
An exstension still on my ToDo-list is to be able to select WP in Atlas.

Test Plan

Verify that the checkbox is indeed disabled and normal population is used even if selecting a scenario with WP on.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Aug 14 2020, 9:48 AM

Owners added a subscriber: Restricted Owners Package.Aug 14 2020, 9:48 AM

Freagarach edited the summary of this revision. (Show Details)Aug 14 2020, 9:50 AM

Harbormaster completed remote builds in B12874: Diff 13186.Aug 14 2020, 9:59 AM

Freagarach requested review of this revision.Aug 14 2020, 9:59 AM

bb accepted this revision.Aug 25 2020, 4:25 PM

bb removed a reviewer: Restricted Owners Package.

This revision is now accepted and ready to land.Aug 25 2020, 4:25 PM

Closed by commit rP23995: Disable WorldPopulation option for scenarios. (authored by Freagarach). · Explain WhyAug 25 2020, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP23995: Disable WorldPopulation option for scenarios..

Thanks for the review @bb :)

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

gamesetup/

Pages/

GameSetupPage/

GameSettings/

Single/

Checkboxes/

WorldPopulation.js

2 lines

Diff 13288

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Checkboxes/WorldPopulation.js

Disable the WordPopulation checkbox for scenarios.ClosedPublicActions