Page MenuHomeWildfire Games

us → µs
AbandonedPublic

Authored by Nescio on Aug 16 2020, 8:31 PM.

Details

Reviewers
Itms
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch replaces the u for micro with µ, because the output looks nicer in the terminal output:

Test Plan

Check for completeness.

Event Timeline

Nescio created this revision.Aug 16 2020, 8:31 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(vfs_path.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1350/display/redirect

Nescio requested review of this revision.Aug 16 2020, 8:38 PM
Nescio added reviewers: Itms, Restricted Owners Package.Aug 16 2020, 8:41 PM
Nescio added inline comments.
source/ps/Profiler2.cpp
605

Shouldn't there be a space inserted, i.e. " µs"?

I'd prefer to have less non-ASCII characters in the code or in the console output. Since we still support old consoles/compilers that might have problems with non-ASCII characters.

Imarok added a subscriber: Imarok.Aug 17 2020, 12:45 PM

I'd prefer to have less non-ASCII characters in the code or in the console output. Since we still support old consoles/compilers that might have problems with non-ASCII characters.

Sounds reasonable for me. In the usual GUI non-ASCIIs should be fine.

Imarok abandoned this revision.Aug 26 2020, 11:48 AM

See comments above.