svn propset for json files
ClosedPublic
Actions

Authored by Nescio on Aug 16 2020, 9:02 PM.

Details

Reviewers

Silier
bb

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23994: Fix lineendings for json files

Summary

This patch standardizes the svn propsets for all .json files:

svn propset svn:mime-type text/json *.json
svn propset svn:eol-style native *.json

On my end arcanists complains when a svn propset is not set. Having to set it for individual files whenever a patch includes a json file can be annoying. Setting it for all json files at once is far more efficient.

Test Plan

Verify everything still works.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Aug 16 2020, 9:02 PM

Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Aug 16 2020, 9:02 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(vfs_path.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1351/display/redirect

Harbormaster completed remote builds in B12898: Diff 13211.Aug 16 2020, 9:07 PM

Nescio requested review of this revision.Aug 16 2020, 9:07 PM

Herald added a reviewer: Silier. · View Herald TranscriptAug 16 2020, 9:07 PM

We should run

svn propset svn:eol-style native $(find . -type f -name "*.json")
svn propset svn:mime-type text/json $(find . -type f -name "*.json")

from time to time in the repo, or let some bot do it

This revision is now accepted and ready to land.Aug 25 2020, 4:15 PM

Closed by commit rP23994: Fix lineendings for json files (authored by bb). · Explain WhyAug 25 2020, 4:19 PM

This revision was automatically updated to reflect the committed changes.

bb added a commit: rP23994: Fix lineendings for json files.

Large Diff

This large diff affects 386 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

l10n/

messages.json

mods/

mod/

l10n/

messages.json

public/

gui/

options/

options.json

l10n/

messages.json

maps/

random/

anatolian_plateau.json

caledonian_meadows.json

cantabrian_highlands.json

canyon.json

continent.json

corinthian_isthmus.json

corsica.json

cycladic_archipelago.json

guadalquivir_river.json

hyrcanian_shores.json

india.json

island_stronghold.json

neareastern_badlands.json

persian_highlands.json

phoenician_levant.json

rhine_marshlands.json

river_archipelago.json

rmbiome/

fields_of_meroe/

generic/

gulf_of_bothnia/

persian_highlands/

sahel_watering_holes.json

schwarzwald.json

scythian_rivulet.json

snowflake_searocks.json

stronghold.json

survivalofthefittest.json

simulation/

ai/

petra/

data.json

data/

auras/

structures/

arsenal_repair.json

barracks_xp_trickle.json

18 lines

cart_super_dock_repair.json

iber_monument.json

kush_pyramids_economic.json

kush_pyramids_military.json

kush_temple_amun.json

teambonuses/

athen_player_teambonus.json

brit_player_teambonus.json

cart_player_teambonus.json

gaul_player_teambonus.json

iber_player_teambonus.json

kush_player_teambonus.json

mace_player_teambonus.json

maur_player_teambonus.json

pers_player_teambonus.json

ptol_player_teambonus.json

rome_player_teambonus.json

sele_player_teambonus.json

spart_player_teambonus.json

units/

catafalques/

athen_catafalque_1.json

athen_catafalque_2.json

brit_catafalque_1.json

brit_catafalque_2.json

cart_catafalque.json

gaul_catafalque_1.json

gaul_catafalque_2.json

iber_catafalque_1.json

iber_catafalque_2.json

kush_catafalque_1.json

kush_catafalque_2.json

mace_catafalque.json

maur_catafalque_1.json

maur_catafalque_2.json

pers_catafalque.json

ptol_catafalque.json

rome_catafalque_1.json

rome_catafalque_2.json

sele_catafalque_1.json

sele_catafalque_2.json

sele_catafalque_3.json

spart_catafalque_1.json

spart_catafalque_2.json

spart_catafalque_3.json

elephant_worker.json

female_inspiration.json

heroes/

athen_hero_iphicrates_1.json

athen_hero_iphicrates_2.json

athen_hero_pericles_1.json

athen_hero_pericles_2.json

athen_hero_themistocles_1.json

athen_hero_themistocles_2.json

brit_hero_boudicca.json

brit_hero_caratacos.json

brit_hero_cunobelin.json

cart_hero_hamilcar_1.json

cart_hero_hamilcar_2.json

cart_hero_hannibal.json

cart_hero_maharbal.json

gaul_hero_brennus.json

gaul_hero_vercingetorix.json

gaul_hero_viridomarus.json

hero_garrison.json

iber_hero_caros_1.json

iber_hero_caros_2.json

iber_hero_indibil.json

iber_hero_viriato_1.json

iber_hero_viriato_2.json

kush_hero_amanirenas.json

kush_hero_arakamani_1.json

kush_hero_arakamani_2.json

kush_hero_arakamani_3.json

kush_hero_nastasen_1.json

kush_hero_nastasen_2.json

mace_hero_alexander_1.json

mace_hero_alexander_2.json

mace_hero_craterus.json

mace_hero_demetrius.json

mace_hero_philip.json

mace_hero_pyrrhus.json

maur_hero_ashoka.json

maur_hero_chanakya_1.json

maur_hero_chanakya_2.json

pers_hero_cyrus.json

pers_hero_darius.json

pers_hero_xerxes.json

ptol_hero_cleopatra_1.json

ptol_hero_cleopatra_2.json

ptol_hero_cleopatra_3.json

ptol_hero_ptolemy_IV.json

ptol_hero_ptolemy_I_1.json

ptol_hero_ptolemy_I_2.json

rome_hero_marcellus_1.json

rome_hero_marcellus_2.json

rome_hero_maximus.json

rome_hero_scipio.json

sele_hero_antiochus_great.json

sele_hero_antiochus_righteous.json

sele_hero_seleucus_victor.json

spart_hero_brasidas.json

spart_hero_leonidas.json

cheats/

changeMaxPopulation.json

researchTechnology.json

civs/

resources/

settings/

population_capacities.json

starting_resources.json

trigger_difficulties.json

victory_conditions/

capture_the_relic.json

conquest.json

conquest_structures.json

conquest_units.json

regicide.json

wonder.json

world_population_capacities.json

technologies/

archery_tradition.json

armor_cav_01.json

armor_cav_02.json

armor_hero_01.json

armor_infantry_01.json

armor_infantry_02.json

armor_ship_hullsheathing.json

armor_ship_hypozomata.json

armor_ship_reinforcedhull.json

attack_cavalry_melee_01.json

attack_cavalry_melee_02.json

attack_cavalry_ranged_01.json

attack_cavalry_ranged_02.json

attack_infantry_melee_01.json

attack_infantry_melee_02.json

attack_infantry_ranged_01.json

attack_infantry_ranged_02.json

attack_soldiers_will.json

attack_steel_working.json

carthaginians/

special_colonisation.json

special_exploration.json

training_phoenician_naval_architects.json

civbonuses/

cart_walls.json

celt_structures.json

greek_structures.json

spart_population.json

gather_animals_stockbreeding.json

gather_capacity_basket.json

gather_capacity_carts.json

gather_capacity_fishing.json

gather_capacity_wheelbarrow.json

gather_farming_fertilizer.json

gather_farming_harvester.json

gather_farming_plows.json

gather_farming_training.json

gather_fishing_net.json

gather_lumbering_ironaxes.json

gather_lumbering_sharpaxes.json

gather_lumbering_strongeraxes.json

gather_mining_serfs.json

gather_mining_servants.json

gather_mining_shaftmining.json

gather_mining_silvermining.json

gather_mining_slaves.json

gather_mining_wedgemallet.json

gather_wicker_baskets.json

health_females_01.json

health_regen_units.json

hellenes/

spartans_agoge.json

special_iphicratean_reforms.json

special_long_walls.json

kushites/

monumental_architecture.json

upgrade_rank_elite_healer.json

persians/

immortals.json

persian_architecture.json

special_equine_transports.json

training_conscription_cavalry.json

training_conscription_infantry.json

training_levy_cavalry.json

training_levy_infantry.json

phase_city.json

phase_city_athen.json

phase_city_generic.json

phase_town.json

phase_town_athen.json

phase_town_generic.json

romans/

vision_sibylline.json

siege_armor.json

siege_attack.json

siege_bolt_accuracy.json

siege_cost_metal.json

siege_cost_wood.json

speed_cavalry_01.json

speed_cavalry_02.json

spy_counter.json

successors/

pair_unlock_champions.json

special_hellenistic_metropolis.json

special_parade_of_daphne.json

special_war_horses.json

unlock_reform_army.json

unlock_traditional_army.json

upgrade_mace_silvershields.json

tower_armour.json

tower_crenellations.json

tower_decay.json

tower_murderholes.json

tower_range.json

tower_vision.json

tower_watch.json

trade_commercial_treaty.json

trade_convoys_armor.json

trade_convoys_speed.json

trade_gain_01.json

trade_gain_02.json

training_conscription.json

training_naval_architects.json

unit_advanced.json

unit_elephant_african.json

unit_elephant_indian.json

unit_elite.json

unlock_champion_units.json

unlock_females_house.json

unlock_shared_dropsites.json

unlock_shared_los.json

unlock_spies.json

upgrade_rank_advanced_mercenary.json

template_helpers/

damage_types/

crush.json

hack.json

pierce.json

tools/

atlas/

svn propset for json filesClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 13287

ps/trunk/binaries/data/l10n/messages.json

ps/trunk/binaries/data/mods/mod/l10n/messages.json

ps/trunk/binaries/data/mods/public/gui/options/options.json

ps/trunk/binaries/data/mods/public/l10n/messages.json

ps/trunk/binaries/data/mods/public/maps/random/aegean_sea.json

ps/trunk/binaries/data/mods/public/maps/random/african_plains.json

ps/trunk/binaries/data/mods/public/maps/random/alpine_lakes.json

ps/trunk/binaries/data/mods/public/maps/random/alpine_valley.json

ps/trunk/binaries/data/mods/public/maps/random/ambush.json

ps/trunk/binaries/data/mods/public/maps/random/anatolian_plateau.json

ps/trunk/binaries/data/mods/public/maps/random/archipelago.json

ps/trunk/binaries/data/mods/public/maps/random/arctic_summer.json

ps/trunk/binaries/data/mods/public/maps/random/ardennes_forest.json

ps/trunk/binaries/data/mods/public/maps/random/atlas_mountains.json

ps/trunk/binaries/data/mods/public/maps/random/bahrain.json

ps/trunk/binaries/data/mods/public/maps/random/belgian_uplands.json

ps/trunk/binaries/data/mods/public/maps/random/botswanan_haven.json

ps/trunk/binaries/data/mods/public/maps/random/caledonian_meadows.json

ps/trunk/binaries/data/mods/public/maps/random/cantabrian_highlands.json

ps/trunk/binaries/data/mods/public/maps/random/canyon.json

ps/trunk/binaries/data/mods/public/maps/random/continent.json

ps/trunk/binaries/data/mods/public/maps/random/corinthian_isthmus.json

ps/trunk/binaries/data/mods/public/maps/random/corsica.json

ps/trunk/binaries/data/mods/public/maps/random/cycladic_archipelago.json

ps/trunk/binaries/data/mods/public/maps/random/danubius.json

ps/trunk/binaries/data/mods/public/maps/random/deep_forest.json

ps/trunk/binaries/data/mods/public/maps/random/dodecanese.json

ps/trunk/binaries/data/mods/public/maps/random/elephantine.json

ps/trunk/binaries/data/mods/public/maps/random/empire.json

ps/trunk/binaries/data/mods/public/maps/random/english_channel.json

ps/trunk/binaries/data/mods/public/maps/random/extinct_volcano.json

ps/trunk/binaries/data/mods/public/maps/random/fields_of_meroe.json

ps/trunk/binaries/data/mods/public/maps/random/flood.json

ps/trunk/binaries/data/mods/public/maps/random/fortress.json

ps/trunk/binaries/data/mods/public/maps/random/frontier.json

ps/trunk/binaries/data/mods/public/maps/random/gear.json

ps/trunk/binaries/data/mods/public/maps/random/guadalquivir_river.json

ps/trunk/binaries/data/mods/public/maps/random/gulf_of_bothnia.json

ps/trunk/binaries/data/mods/public/maps/random/harbor.json

ps/trunk/binaries/data/mods/public/maps/random/hellas.json

ps/trunk/binaries/data/mods/public/maps/random/hellas_biomes.json

ps/trunk/binaries/data/mods/public/maps/random/hells_pass.json

ps/trunk/binaries/data/mods/public/maps/random/hyrcanian_shores.json

ps/trunk/binaries/data/mods/public/maps/random/india.json

ps/trunk/binaries/data/mods/public/maps/random/island_stronghold.json

ps/trunk/binaries/data/mods/public/maps/random/islands.json

ps/trunk/binaries/data/mods/public/maps/random/jebel_barkal.json

ps/trunk/binaries/data/mods/public/maps/random/kerala.json

ps/trunk/binaries/data/mods/public/maps/random/lake.json

ps/trunk/binaries/data/mods/public/maps/random/latium.json

ps/trunk/binaries/data/mods/public/maps/random/lions_den.json

ps/trunk/binaries/data/mods/public/maps/random/lorraine_plain.json

ps/trunk/binaries/data/mods/public/maps/random/lower_nubia.json

ps/trunk/binaries/data/mods/public/maps/random/mainland.json

ps/trunk/binaries/data/mods/public/maps/random/marmara.json

ps/trunk/binaries/data/mods/public/maps/random/mediterranean.json

ps/trunk/binaries/data/mods/public/maps/random/migration.json

ps/trunk/binaries/data/mods/public/maps/random/neareastern_badlands.json

ps/trunk/binaries/data/mods/public/maps/random/new_rms_test.json

ps/trunk/binaries/data/mods/public/maps/random/ngorongoro.json

ps/trunk/binaries/data/mods/public/maps/random/northern_lights.json

ps/trunk/binaries/data/mods/public/maps/random/oasis.json

ps/trunk/binaries/data/mods/public/maps/random/persian_highlands.json

ps/trunk/binaries/data/mods/public/maps/random/phoenician_levant.json

ps/trunk/binaries/data/mods/public/maps/random/polar_sea.json

ps/trunk/binaries/data/mods/public/maps/random/pompeii.json

ps/trunk/binaries/data/mods/public/maps/random/pyrenean_sierra.json

ps/trunk/binaries/data/mods/public/maps/random/ratumacos.json

ps/trunk/binaries/data/mods/public/maps/random/red_sea.json

ps/trunk/binaries/data/mods/public/maps/random/rhine_marshlands.json

ps/trunk/binaries/data/mods/public/maps/random/river_archipelago.json

ps/trunk/binaries/data/mods/public/maps/random/rivers.json

ps/trunk/binaries/data/mods/public/maps/random/rmbiome/defaultbiome.json

svn propset for json files
ClosedPublic
Actions

Revision Contents
Changeset List