Page MenuHomeWildfire Games
Differential D296

Fix, remove and add loading screen quotes
ClosedPublic
Actions

Authored by Phormio on Apr 6 2017, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 6:34 AM
Unknown Object (File)
Sun, Sep 8, 1:07 PM
Unknown Object (File)
Fri, Sep 6, 1:05 AM
Unknown Object (File)
Wed, Sep 4, 11:46 PM
Unknown Object (File)
Wed, Sep 4, 11:41 PM
Unknown Object (File)
Wed, Sep 4, 11:41 PM
Unknown Object (File)
Wed, Sep 4, 11:41 PM
Unknown Object (File)
Wed, Sep 4, 11:41 PM
View All 16 Files
Subscribers
elexis
Gallaecio
Hannibal_Barca
Itms
Restricted Owners Package

Details

Reviewers
Gallaecio
Itms
Commits
rP19529: Revamp of the quotes in the game loading screen, research and patch by Phormio.
Summary

There was a previous, far inferior version of this revision, don't get confused by it.
This is my final version, with the following changes.

  • removed lots of false quotes in case their source was not ancient, they could not be found or were misleading in context
  • removed lots of boring quotes
  • added lots of new quotes (500 characters max., some may still be too long)
  • all quotes include their source
  • many quotes reworded and translated into modern English
  • many quotes improved by providing historical context
  • removed useless string "Quote of the Day"
Test Plan

Not applicable. All quotations were obviously checked for accuracy and spelling errors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Phormio created this revision.Apr 6 2017, 5:27 PM
Owners added a subscriber: Restricted Owners Package.Apr 6 2017, 5:27 PM
elexis added a subscriber: elexis.Apr 6 2017, 5:34 PM

Where are they from?

Phormio added a comment.Apr 6 2017, 5:45 PM
In D296#11724, @elexis wrote:

Where are they from?

Mostly Wikiquote and free translations of ancient sources like Perseus Project. Whoever worked on this before me obviously copied most quotes from Wikiquote--thus while exact citations would be better, nothing gets worse.

Hannibal_Barca added a subscriber: Hannibal_Barca.Apr 10 2017, 3:56 PM

This might not be the place for it but i think the "Quote of the day" line should be just removed. Everyone knows a quote when they see one and "Quote of the day" isn't correct since we get a new quote every game. "Quote" or "Quote of the game" seems unnecessary so it would be nice to remove that line totally and have something like in Total War.

Phormio added a comment.Apr 15 2017, 11:50 AM
In D296#12264, @Hannibal_Barca wrote:

This might not be the place for it but i think the "Quote of the day" line should be just removed. Everyone knows a quote when they see one and "Quote of the day" isn't correct since we get a new quote every game. "Quote" or "Quote of the game" seems unnecessary so it would be nice to remove that line totally and have something like in Total War.

Have you submitted a patch that removes the phrase?

Phormio updated this revision to Diff 1532.Apr 29 2017, 3:17 PM

Cyrus' quotations now in alphabetical order and without duplicate, added quotations by Terence and Ennius, removed boring and misleading quotation by Aristotle about poetry

Harbormaster completed remote builds in B1332: Diff 1532.Apr 29 2017, 3:17 PM
Gallaecio accepted this revision.May 1 2017, 7:06 AM
Gallaecio added a subscriber: Gallaecio.

All new quotes seem to come from external, reliable sources (i.e. not translated by the patch author himself), so while I may not totally agree with some of them, I expect them to be widely accepted nonetheless. +1 for me.

This revision is now accepted and ready to land.May 1 2017, 7:06 AM
elexis added a comment.May 1 2017, 6:16 PM

phormio you mentioned that you have "been double-checking the quotes for a while now and found many are unsourced."
Do you intend to remove them? I guess one could also prefix those with "Attributed:" if ther is no source, just to make this obvious that we don't know if that quote (or something with the same meaning) is actually true.

I'm not entirely convinced that Wikiquote is a reliable source. If we want to make it really proper, we'd cite the origin as we do in science in general

binaries/data/mods/public/gui/text/quotes.txt
199

Isn't this from Artemisia I? couldn't find a source quickly

200

For example "Source/Notes: Ahunuvaiti Gatha; Yasna 30, 9. - The Gathas" from http://izquotes.com/quote/280603
Would be much more reliable and the proof would be reproducible

Phormio updated this revision to Diff 1692.May 6 2017, 7:52 PM
  • removed lots of false quotes in case their source was not ancient, they could not be found or were misleading in context
  • removed lots of boring quotes
  • added lots of new quotes (500 characters max., some may still be too long)
  • all quotes include their source
  • many quotes reworded and translated into modern English
  • many quotes improved by providing historical context
  • removed useless string "Quote of the Day"
Phormio updated this revision to Diff 1693.May 6 2017, 7:59 PM

fixed typos

Phormio edited the summary of this revision. (Show Details)May 6 2017, 8:10 PM
Phormio added a comment.May 6 2017, 8:33 PM
In D296#16717, @elexis wrote:

phormio you mentioned that you have "been double-checking the quotes for a while now and found many are unsourced."
Do you intend to remove them? I guess one could also prefix those with "Attributed:" if ther is no source, just to make this obvious that we don't know if that quote (or something with the same meaning) is actually true.

I'm not entirely convinced that Wikiquote is a reliable source. If we want to make it really proper, we'd cite the origin as we do in science in general

Fixed now.

Phormio added a comment.May 6 2017, 8:35 PM
In D296#12264, @Hannibal_Barca wrote:

This might not be the place for it but i think the "Quote of the day" line should be just removed. Everyone knows a quote when they see one and "Quote of the day" isn't correct since we get a new quote every game. "Quote" or "Quote of the game" seems unnecessary so it would be nice to remove that line totally and have something like in Total War.

Done.

Phormio updated this revision to Diff 1716.May 7 2017, 1:51 PM

typos

Phormio updated this revision to Diff 1719.May 7 2017, 4:21 PM

typos

Harbormaster completed remote builds in B1519: Diff 1719.May 7 2017, 4:21 PM
Itms requested changes to this revision.May 7 2017, 6:31 PM
Itms added a subscriber: Itms.

Just a few things I noticed, I hope I didn't miss too many of them.

Very nice patch! Are you already in the Credits? You can add yourself in the History section, if you want to (binaries/data/mods/public/gui/credits/texts/misc.json).

binaries/data/mods/public/gui/text/quotes.txt
22

"valor" in US English.

27

Use apostrophe and not right single quotation mark for genitive.

48

extra space before the parenthesis

49

"gold" without capital

63

period

64

period

74

does

81

extra space after Caesar

135

dishonor

161

extra space before the parenthesis

168

honor

171

favors

This revision now requires changes to proceed.May 7 2017, 6:31 PM
Phormio updated this revision to Diff 1725.May 7 2017, 6:49 PM
Phormio edited edge metadata.
  • fixed errors found by Itms
  • added missing periods for each sentence (some were overlooked by Itms)
Itms accepted this revision.May 7 2017, 11:57 PM

Great work!

This revision is now accepted and ready to land.May 7 2017, 11:57 PM
Closed by commit rP19529: Revamp of the quotes in the game loading screen, research and patch by Phormio. (authored by Itms). · Explain WhyMay 8 2017, 12:05 AM
This revision was automatically updated to reflect the committed changes.
elexis edited the summary of this revision. (Show Details)May 8 2017, 2:41 AM
elexis added a comment.May 8 2017, 2:46 AM

Thanks for digging out the source for the quotes. Not only makes this more credible than all the random quote pages but might inspire players also to start looking up historical references if they want to find out more and is another step towards actually fulfilling the mandate to be a somewhat educational. game as well.

Phormio updated this revision to Diff 1851.May 11 2017, 7:56 PM

added two missing backslashes for opening square brackets

Phormio mentioned this in rP19529: Revamp of the quotes in the game loading screen, research and patch by Phormio..May 11 2017, 7:58 PM
elexis retitled this revision from quotations added, fixed and removed if wrong to Fix, remove and add loading screen quotes.May 16 2017, 3:18 PM
Imarok mentioned this in D2832: Remove inappropriate quote about women.Jun 23 2020, 7:42 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
text/
4 lines

Diff 1851

View Options

binaries/data/mods/public/gui/text/quotes.txt

Loading...
Wildfire Games · Phabricator