Not that I've found. The other places that don't check are explicitly in the "hunt-gathering" state where lastPos ought to always exist <=> lasPos not existing is a different bug.

I came to the same conclusion :)

You could clean it up a little by not creating the variable and combine the condition with the if-else a few lines earlier.

This revision is now accepted and ready to land.Aug 17 2020, 10:08 AM

Uhm, what happens when there is no lastPos and an entity gets movementUpdate.failure? They're stuck then, right?

In D2960#129087, @Freagarach wrote:

Uhm, what happens when there is no lastPos and an entity gets movementUpdate.failure? They're stuck then, right?

Mh, you're correct. Can only happen with formations, but then we do have entities stuck in their state.

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1356/display/redirect

Harbormaster completed remote builds in B12903: Diff 13216.Aug 17 2020, 10:44 AM

wraitii requested review of this revision.Aug 17 2020, 10:52 AM

Freagarach added inline comments.Aug 17 2020, 10:56 AM

binaries/data/mods/public/simulation/components/UnitAI.js
1897 ↗	(On Diff #13216)	We'd still want to try and find a new target?

wraitii added inline comments.Aug 17 2020, 11:08 AM

binaries/data/mods/public/simulation/components/UnitAI.js
1897 ↗	(On Diff #13216)	This can only happen when in formation, so aborting seemed reasonable enough to me, but I'm not too sure.

After a good night's sleep it obviously makes more sense to do this.

Looks good now, playtesting reveals no errors.

This revision is now accepted and ready to land.Aug 18 2020, 8:59 AM

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1369/display/redirect

Harbormaster completed remote builds in B12921: Diff 13236.Aug 18 2020, 9:17 AM

Closed by commit rP23970: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425] (authored by wraitii). · Explain WhyAug 18 2020, 9:46 AM

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP23970: Check for lastPos existence in Combat-Approaching-MovementUpdate [fix rP22425].