Fixes a TODO in input.js
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24159: Play a sound on invalid building placement.
Try to place a building on an invalid location
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK Severity Location Code Message Warning binaries/data/mods/public/gui/session/input.js:241 ESLintBear (no-undef-init) ESLintBear (no-undef-init) Warning binaries/data/mods/public/gui/session/input.js:477 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:492 ESLintBear (operator-linebreak) ESLintBear (operator-linebreak) Warning binaries/data/mods/public/gui/session/input.js:504 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:508 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:563 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:573 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:621 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:650 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/input.js:652 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:653 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:655 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:656 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:657 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:658 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:659 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:660 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:661 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:662 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:663 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:665 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:666 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:668 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:669 ESLintBear (indent) ESLintBear (indent) Warning binaries/data/mods/public/gui/session/input.js:670 ESLintBear (indent) ESLintBear (indent) - Unit
No Unit Test Coverage - Build Status
Buildable 12956 Build 25496: Vulcan Build Jenkins Build 25495: Vulcan Build (macOS) Jenkins Build 25494: Vulcan Build (Windows) Jenkins Build 25493: arc lint + arc unit
Event Timeline
Comment Actions
Code looks good.
Not sure if interface/ui is the proper place for this sound. It doesn't really relate to chat pings or so. Maybe one can consider it an alarm? Anyway, sound is not my department.
Comment Actions
I guess UI is fine. Who _is_ in charge of sound? ^^'
| binaries/data/mods/public/simulation/templates/template_unit.xml | ||
|---|---|---|
| 111 | Perhaps only add to the entities with a build list? | |
Comment Actions
I'm in charge of the sound communication, so everything goes through me to Samulis and Omri :)
| binaries/data/mods/public/simulation/templates/template_unit.xml | ||
|---|---|---|
| 111 | Would make it more prone for omission no? | |