Page MenuHomeWildfire Games
Differential D2977

Fix StatusEffects not being applied after rP24001.
ClosedPublic
Actions

Authored by Freagarach on Aug 27 2020, 6:51 PM.

Details

Reviewers
bb
Commits
rP24004: Fix applying StatusEffects after rP24001.
Summary

rP24001 Broke StatusEffects being applied. This fixes that.

Test Plan

Review code, check that StatusEffecs *are* applied now.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Aug 27 2020, 6:51 PM
Harbormaster completed remote builds in B13008: Diff 13315.Aug 27 2020, 6:56 PM
Freagarach requested review of this revision.Aug 27 2020, 6:57 PM
Freagarach updated this revision to Diff 13316.Aug 27 2020, 7:04 PM

Add test.

Harbormaster completed remote builds in B13009: Diff 13316.Aug 27 2020, 7:09 PM
Freagarach mentioned this in rP24001: Rename Armour to Resistance and change the way it is processed..Aug 28 2020, 8:36 AM
bb accepted this revision.Aug 28 2020, 2:32 PM
bb removed a reviewer: Restricted Owners Package.

grepped for completion that all HandleAttackEffects got a treatment (should have done that earlier)

binaries/data/mods/public/simulation/helpers/Attacking.js
173 ↗(On Diff #13316)

Needs change

This revision is now accepted and ready to land.Aug 28 2020, 2:32 PM
Closed by commit rP24004: Fix applying StatusEffects after rP24001. (authored by Freagarach). · Explain WhyAug 28 2020, 2:43 PM
This revision was automatically updated to reflect the committed changes.
Freagarach added a commit: rP24004: Fix applying StatusEffects after rP24001..
Freagarach added a comment.Aug 28 2020, 2:44 PM

Thanks for the review @bb :)

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
2 lines
tests/
2 lines
helpers/
4 lines
tests/
22 lines

Diff 13320

View Options

ps/trunk/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_StatusEffectsReceiver.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Attacking.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/tests/test_Attacking.js

Loading...
Wildfire Games · Phabricator