[WIP] - Update tooltips after rP24001.
AbandonedPublic
Actions

Authored by Freagarach on Aug 28 2020, 10:17 AM.

Details

Reviewers

Summary

This updates tooltips after rP24001, to use damage resistance where formerly armor was used.
Update style guide afterwards.

This only update a few lines to discuss the implementation, when that is settled the rest can be updated too.

Test Plan

Discuss the text. Verify its completeness.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 13012
Build 25679: Vulcan Build	Jenkins
Build 25678: Vulcan Build (macOS)	Jenkins
Build 25677: Vulcan Build (Windows)	Jenkins
Build 25676: arc lint + arc unit

Event Timeline

Freagarach created this revision.Aug 28 2020, 10:17 AM

Owners added a subscriber: Restricted Owners Package.Aug 28 2020, 10:17 AM

Freagarach mentioned this in rP24001: Rename Armour to Resistance and change the way it is processed..Aug 28 2020, 10:17 AM

Harbormaster completed remote builds in B13012: Diff 13319.Aug 28 2020, 10:24 AM

Freagarach requested review of this revision.Aug 28 2020, 10:24 AM

It's consistent with gui/common/tooltips.js line 193.

Verify its completeness.

Incomplete.
Furthermore, quite a few technologies have "armor" in their name; should those be renamed too?

binaries/data/mods/public/simulation/data/technologies/unit_elite.json
4	Maybe list after health?

This revision now requires changes to proceed.Aug 28 2020, 10:40 AM

In D2978#130044, @Nescio wrote:

Incomplete.

This only update a few lines to discuss the implementation, when that is settled the rest can be updated too.

binaries/data/mods/public/simulation/data/technologies/unit_elite.json
4	And why that, if I may ask?

Nescio added inline comments.Aug 28 2020, 10:53 AM

binaries/data/mods/public/simulation/data/technologies/unit_elite.json
4	The tooltip order is apparently: costs (resources, population, time); “passive” stats (e.g. health, capture points, garrison capacity); “action” stats (e.g. attack, heal, resource gatherer). I believe armour used to be listed before health because A precedes H; now it has been renamed to resistance, hence my question.

In D2978#130044, @Nescio wrote:

Furthermore, quite a few technologies have "armor" in their name; should those be renamed too?

Not necessarily imo, as armour remains intuitive as "damage resistance". Do you mean "armour" in the json file name or the actual name?

In D2978#130044, @Nescio wrote:

Furthermore, quite a few technologies have "armor" in their name; should those be renamed too?

I don't think so, it matches the description, right?

Not necessarily imo, as armour remains intuitive as "damage resistance". Do you mean "armour" in the json file name or the actual name?

The file name; e.g. armor_infantry_01.json might be fine, but e.g. tower_armour.json doesn't really make much sense any more, does it?

I don't think so, it matches the description, right?

You mean the "description" field inside the technology json file?

The tower_armour is a good point, yes. There it doesn't match the description inside the json-files.

Technology tooltips were checked and corrected in D3338/rP24564, so you should rebase this and focus on doing the armour→resistance correction in aura descriptions.