Paths

Table of Contentst

Differential D2981

Add back safeguard against killing an entity multiple times.
ClosedPublic
Actions

Authored by Freagarach on Aug 29 2020, 7:14 AM.

Details

Reviewers

Silier

Commits

rP24006: Readd safeguard against killing an entity multiple times.

Summary

Regression of rP24001.

Test Plan

Review code.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Aug 29 2020, 7:14 AM

Could also just check for this.hitpoints && amount prior to reducing?

Harbormaster completed remote builds in B13026: Diff 13336.Aug 29 2020, 7:24 AM

Freagarach requested review of this revision.Aug 29 2020, 7:24 AM

yes there is no point to call that function if one of it is zero

Check earlier.

Silier accepted this revision.Aug 29 2020, 7:36 AM

This revision is now accepted and ready to land.Aug 29 2020, 7:36 AM

Harbormaster completed remote builds in B13027: Diff 13337.Aug 29 2020, 7:38 AM

Closed by commit rP24006: Readd safeguard against killing an entity multiple times. (authored by Freagarach). · Explain WhyAug 29 2020, 7:47 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP24006: Readd safeguard against killing an entity multiple times..

Freagarach added inline comments.Aug 29 2020, 7:49 AM

ps/trunk/binaries/data/mods/public/simulation/components/Health.js
238	(We should throw a error here when trying to subtract a negative amount.)

Thanks for the quick review @Angen :)

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Health.js

3 lines

Diff 13338

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Health.js

Add back safeguard against killing an entity multiple times.ClosedPublicActions