Page MenuHomeWildfire Games

[gui] omit resource trickle and loot from attack & resistance tooltip
Needs ReviewPublic

Authored by Nescio on Sep 3 2020, 12:45 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Loot and resource trickle are not very important, therefore this patch removes them from the “Attack and Resistance” tooltip (the one that pops up when hovering the cursor over the arms icon in the centre of the single details panel).
Before:


After:

They're still displayed in the extended details panel, which opens when you right-click on an entity icon.

See also D2247, D2980, D2984.

Test Plan

Agree this is an improvement.

Event Timeline

Nescio created this revision.Sep 3 2020, 12:45 PM
Owners added a subscriber: Restricted Owners Package.Sep 3 2020, 12:45 PM
Nescio requested review of this revision.Sep 3 2020, 12:50 PM

Not sure about the unimportance of the resource trickle.

Nescio added a comment.Sep 3 2020, 2:27 PM

Not sure about the unimportance of the resource trickle.

The attack & resistance tooltip doesn't have e.g. getPopulationBonusTooltip (i.e. population limit) or getAurasTooltip either, which are more important, and are included in the short pop-up when hovering over the entity icon in the right selection panel, which doesn't have getResourceTrickleTooltip or getLootTooltip either.

Freagarach added a comment.EditedSep 17 2020, 11:20 AM

Perhaps this could be moved to the tooltip of the entity icon?

Perhaps this could be moved to the tooltip of the entity icon?

Which tooltip do you mean exactly?
Loot and resource trickle are already displayed in the one that pops up when hovering over an icon in the structure tree, as well as in the one that opens when right-clicking on an entity icon.

in the one that opens when right-clicking on an entity icon.

Hmm, maybe that is indeed enough,,,

I meant the tooltip that pops up when hovering the icon in the single selection screen (middle).

In my opinion the tooltip that opens when right-clicking on a entity icon should list everything (as is already the case), but the smaller ones that pop up when hovering over an icon ought to display only the most important and relevant information, hence this patch.

Agreed, but then there is the question what is ,,only the most important and relevant information'' ;)

That varies from case to case. For attack & resistance specifically, I suppose only combat and action (e.g. healer, gatherer) stats.

Angen added a subscriber: Angen.Sep 17 2020, 1:27 PM

instead of removing this information, maybe it could be moved to extended version of tooltip