Page MenuHomeWildfire Games

Allow entities without cmpResistance.
AbandonedPublic

Authored by Freagarach on Sep 4 2020, 9:36 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This adds a "hint" to the templates that an entity is attackable, that can be used in range queries.
This component can later be used to distribute automated attacks (refs #1847).

Test Plan

Verify that effectively nothing has changed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:121ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:122ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:126ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:129ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (brace-rules/brace-on-same-line)ESLintBear (brace-rules/brace-on-same-line)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (no-else-return)ESLintBear (no-else-return)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:131ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:132ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:136ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:140ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:141ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:145ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:146ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:147ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:158ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:162ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:166ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:167ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:168ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:169ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:170ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:184ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:188ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:188ESLintBear (quote-props)ESLintBear (quote-props)
Unit
No Unit Test Coverage
Build Status
Buildable 13347
Build 26768: Vulcan BuildJenkins
Build 26767: Vulcan Build (macOS)Jenkins
Build 26766: Vulcan Build (Windows)Jenkins
Build 26765: arc lint + arc unit

Event Timeline

Freagarach created this revision.Sep 4 2020, 9:36 PM
Owners added a subscriber: Restricted Owners Package.Sep 4 2020, 9:36 PM
Freagarach requested review of this revision.Sep 4 2020, 9:41 PM
Freagarach edited the summary of this revision. (Show Details)Sep 5 2020, 8:14 AM
Freagarach updated this revision to Diff 13636.Oct 16 2020, 2:26 PM

Rebased and linter.

Or cmpTargetable and use it also for healing (to inform the healer that we have for example) instead of listening to global ownership changes.

Freagarach abandoned this revision.Thu, Mar 25, 6:57 PM

After some good thought, this seems indeed very redundant. Every action component (e.g. cmpHeal, cmpAttack) has a receiver component (e.g. Health, Resistance).
Those receiver components can very well be used as the "targetable" components (see e.g. resource gathering).