Page MenuHomeWildfire Games
Differential D2994

Allow entities without cmpResistance.
Needs ReviewPublic
Actions

Authored by Freagarach on Sep 4 2020, 9:36 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This adds a "hint" to the templates that an entity is attackable, that can be used in range queries.
This component can later be used to distribute automated attacks (refs #1847).

Test Plan

Verify that effectively nothing has changed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:121ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:122ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:126ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:129ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (brace-rules/brace-on-same-line)ESLintBear (brace-rules/brace-on-same-line)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (no-else-return)ESLintBear (no-else-return)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:130ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:131ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:132ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:136ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:140ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:141ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:145ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:146ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:147ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:158ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:162ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:166ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:167ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:168ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:169ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:170ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:184ESLintBear (quote-props)ESLintBear (quote-props)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:188ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/tests/test_UnitAI.js:188ESLintBear (quote-props)ESLintBear (quote-props)
Unit
No Unit Test Coverage
Build Status
Buildable 13347
Build 26768: Vulcan BuildJenkins
Build 26767: Vulcan Build (macOS)Jenkins
Build 26766: Vulcan Build (Windows)Jenkins
Build 26765: arc lint + arc unit

Event Timeline

Freagarach created this revision.Sep 4 2020, 9:36 PM
Owners added a subscriber: Restricted Owners Package.Sep 4 2020, 9:36 PM
Harbormaster completed remote builds in B13097: Diff 13407.Sep 4 2020, 9:41 PM
Freagarach requested review of this revision.Sep 4 2020, 9:41 PM
Freagarach edited the summary of this revision. (Show Details)Sep 5 2020, 8:14 AM
Freagarach added a child revision: D1268: Remove health component from relics..Sep 11 2020, 2:53 PM
Freagarach added a child revision: D2129: Let entity react on target death directly..Sep 17 2020, 10:22 AM
Freagarach updated this revision to Diff 13636.Oct 16 2020, 2:26 PM

Rebased and linter.

Harbormaster completed remote builds in B13347: Diff 13636.Oct 16 2020, 2:39 PM
Freagarach added a comment.Nov 13 2020, 10:07 AM

Or cmpTargetable and use it also for healing (to inform the healer that we have for example) instead of listening to global ownership changes.

Freagarach removed a child revision: D1268: Remove health component from relics..Dec 1 2020, 7:13 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
components/
11 lines
4 lines
2 lines
4 lines
2 lines
interfaces/
1 line
tests/
1 line
1 line
helpers/
2 lines
templates/
1 line
1 line

Diff 13636

View Options

binaries/data/mods/public/simulation/components/Attackable.js

Loading...
View Options

binaries/data/mods/public/simulation/components/BuildingAI.js

Loading...
View Options

binaries/data/mods/public/simulation/components/DelayedDamage.js

Loading...
View Options

binaries/data/mods/public/simulation/components/Resistance.js

Loading...
View Options

binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
View Options

binaries/data/mods/public/simulation/components/interfaces/Attackable.js

Loading...
View Options

binaries/data/mods/public/simulation/components/tests/test_Damage.js

Loading...
View Options

binaries/data/mods/public/simulation/components/tests/test_UnitAI.js

Loading...
View Options

binaries/data/mods/public/simulation/helpers/Attacking.js

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_structure.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit.xml

Loading...
Wildfire Games · Phabricator