Page MenuHomeWildfire Games

[work in progress] clean up and improve consistency in structure templates
Needs ReviewPublic

Authored by Nescio on Sun, Sep 6, 1:06 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch does the following clean up of structure templates:

  • Moves footprint, obstruction, foundation actor, and rubble from generic template_structure* to specific structures/* templates, where the actors are defined. (Exceptions include fields and outposts.) TODO: military structures
  • Inserts footprints in default skirmish structures that didn't have them yet.
  • Removes unused build restriction categories.
  • Changes vision range of template_structure.xml to 1 and moves 40 to the relevant childreb, because 1 is usable for far more of its children than 40.
  • Sets foundation resistance to 1/5/1 for all structures (effect on gameplay balance is presumably neglibible).
  • Removes some other unnecessary lines.
  • Fixes tooltips of embassies and mercenaries camps.
  • Moves phase requirement, health, and sounds from template_structure_special.xml to its children that didn't have it already.
  • Changes parent of cart_super_dock.xml, iber_monument.xml, maur_pillar_ashoka.xml, ptol_lighthouse.xml, and rome_arch.xml from template_structure_special.xml to template_structure.xml, since the former did not really add anything useful.

Similar patches include:

Test Plan

Check for correctness and completeness. Verify all structures still work.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:144JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:147JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:149ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:149JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:167JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:217ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:217ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:219ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:219ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:241JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:242JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:247ESLintBear (no-shadow)ESLintBear (no-shadow)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:256ESLintBear (no-shadow)ESLintBear (no-shadow)
Warningbinaries/data/mods/public/simulation/components/BuildRestrictions.js:277ESLintBear (no-shadow)ESLintBear (no-shadow)
Unit
No Unit Test Coverage
Build Status
Buildable 13115
Build 26027: Vulcan BuildJenkins
Build 26026: Vulcan Build (macOS)Jenkins
Build 26025: Vulcan Build (Windows)Jenkins
Build 26020: arc lint + arc unit

Event Timeline

Nescio created this revision.Sun, Sep 6, 1:06 AM
Owners added a subscriber: Restricted Owners Package.Sun, Sep 6, 1:07 AM
Nescio requested review of this revision.Sun, Sep 6, 1:18 AM