This will help ai mainly on flat maps to place foundations out of fire range of enemy structures, so Petra will less likely lose resources because of useless trying to build stuctures again at some place.
This does not solve elevation bonus given by terrain hight or foundations destroyed by enemy ranged units.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Check that number literals are squared correctly.
Check squared parabolic ranges are compared with squared distances.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK Severity Location Code Message Error binaries/data/mods/public/simulation/ai/common-api/entity.js:984 ESLintBear (no-use-before-define) ESLintBear (no-use-before-define) Warning binaries/data/mods/public/simulation/ai/common-api/entity.js:778 ESLintBear (no-extra-semi) ESLintBear (no-extra-semi) Warning binaries/data/mods/public/simulation/ai/common-api/entity.js:778 JSHintBear JSHintBear Warning binaries/data/mods/public/simulation/ai/common-api/entity.js:837 ESLintBear (brace-rules/brace-on-same-line) ESLintBear (brace-rules/brace-on-same-line) Warning binaries/data/mods/public/simulation/ai/common-api/entity.js:854 ESLintBear (brace-rules/brace-on-same-line) ESLintBear (brace-rules/brace-on-same-line) - Unit
No Unit Test Coverage - Build Status
Buildable 13130 Build 26081: Vulcan Build Jenkins Build 26080: Vulcan Build (macOS) Jenkins Build 26079: Vulcan Build (Windows) Jenkins Build 26078: arc lint + arc unit
Event Timeline
Shouldn't we do something similar for all attackRange queries in the ai?
binaries/data/mods/public/simulation/ai/petra/headquarters.js | ||
---|---|---|
2478 | attackRange might be a better name |
Successful build - Chance fights ever on the side of the prudent.
builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1525/display/redirect
binaries/data/mods/public/simulation/ai/common-api/utils.js | ||
---|---|---|
30 ↗ | (On Diff #13456) | forgot to rename |
binaries/data/mods/public/simulation/ai/petra/attackPlan.js | ||
1544 ↗ | (On Diff #13456) | ouch |
binaries/data/mods/public/simulation/ai/petra/defenseManager.js | ||
589 ↗ | (On Diff #13456) | hmm, what to do here, it is fishing boat so meh ? but I want to avoid sqrt |
binaries/data/mods/public/simulation/ai/petra/headquarters.js | ||
2481 | could do radius*radius out of loop |
binaries/data/mods/public/simulation/ai/petra/attackManager.js | ||
---|---|---|
179 ↗ | (On Diff #13457) | need sqrt here |
binaries/data/mods/public/simulation/ai/petra/attackPlan.js | ||
1549 ↗ | (On Diff #13457) | issue |
1552 ↗ | (On Diff #13457) | range = 8100 |
binaries/data/mods/public/simulation/ai/petra/defenseManager.js | ||
142 ↗ | (On Diff #13457) | issue |
binaries/data/mods/public/simulation/ai/petra/headquarters.js | ||
2481 | issue |
binaries/data/mods/public/simulation/ai/petra/attackManager.js | ||
---|---|---|
179 ↗ | (On Diff #13457) |
Could square the dist ? |
binaries/data/mods/public/simulation/ai/petra/attackManager.js | ||
---|---|---|
179 ↗ | (On Diff #13457) | hmmm, yes |
loose
Is this some kind of sociolect? I'm asking because I've also observed other team members write ‘loose’ (i.e. set free, release) instead of ‘lose’ (i.e. be deprived of, cease to have) more than once.