Page MenuHomeWildfire Games

Do not display right click tooltip when it is not supported right now
Needs ReviewPublic

Authored by Angen on Sun, Sep 6, 4:40 PM.
This revision needs review, but there are no reviewers specified.



disable tooltip to right click on buttons when it is not supported to not cause confusion for users

Test Plan

Check tooltip is displayed when right click action is possible, else it is hidden.

Diff Detail

rP 0 A.D. Public Repository
Lint OK
Warningbinaries/data/mods/public/gui/session/selection_panels.js:50ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:61ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:302ESLintBear (no-multi-spaces)ESLintBear (no-multi-spaces)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:729ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:763ESLintBear (space-before-function-paren)ESLintBear (space-before-function-paren)
No Unit Test Coverage
Build Status
Buildable 13133
Build 26091: Vulcan BuildJenkins
Build 26090: Vulcan Build (macOS)Jenkins
Build 26089: Vulcan Build (Windows)Jenkins
Build 26088: arc lint + arc unit

Event Timeline

Angen created this revision.Sun, Sep 6, 4:40 PM
Owners added a subscriber: Restricted Owners Package.Sun, Sep 6, 4:40 PM
Angen requested review of this revision.Sun, Sep 6, 4:45 PM
bb added a subscriber: bb.Sun, Sep 6, 9:05 PM

Don't feel this is the correct way of approaching the issue. I rather have the buttons enabled for the right click.

Angen added a comment.Mon, Sep 7, 8:29 AM

sure, if that diff makes it to a24, it would be great

Krinkle added a subscriber: Krinkle.