Page MenuHomeWildfire Games

[gui] correct some strings
Needs ReviewPublic

Authored by Nescio on Sat, Sep 12, 1:57 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Various related string corrections in the gui/ files:

  • Learn To Play → Learn to Play (articles, conjunctions, and prepositions are not capitalized in title case, unless it's the first word)
  • Anti-Aliasing → antialiasing (missed in D2437/rP23368)
  • Control Group Membership → Control group membership (added in D2176/rP23476)
  • setup (verb) → set up
  • gamesetup → game setup
  • gamesetting → game setting
  • gamespeed → game speed
Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/gui/common/gamedescription.js:105ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/common/gamedescription.js:106ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/common/gamedescription.js:107ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/common/gamedescription.js:108ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/common/gamedescription.js:109ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/common/gamedescription.js:110ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSetupPage.js:49ESLintBear (semi)ESLintBear (semi)
Warningbinaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSetupPage.js:49JSHintBearJSHintBear
Warningbinaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js:215ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/gui/replaymenu/replay_filters.js:189ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/session.js:699ESLintBear (no-shadow)ESLintBear (no-shadow)
Warningbinaries/data/mods/public/gui/session/session.js:700ESLintBear (no-shadow)ESLintBear (no-shadow)
Warningbinaries/data/mods/public/gui/session/session.js:701ESLintBear (no-shadow)ESLintBear (no-shadow)
Unit
No Unit Test Coverage
Build Status
Buildable 13173
Build 26219: Vulcan BuildJenkins
Build 26218: Vulcan Build (macOS)Jenkins
Build 26217: Vulcan Build (Windows)Jenkins
Build 26216: arc lint + arc unit

Event Timeline

Nescio created this revision.Sat, Sep 12, 1:57 PM
Owners added a subscriber: Restricted Owners Package.Sat, Sep 12, 1:57 PM
Nescio requested review of this revision.Sat, Sep 12, 2:07 PM