Page MenuHomeWildfire Games

Correctize cost tooltip for upgrades
AcceptedPublic

Authored by bb on Mon, Sep 14, 9:01 PM.

Details

Reviewers
elexis
Freagarach
Summary

As noticed in D2654, free upgrades give redundant newline in the tooltip. Also the Cost header isn't shown for upgrades in the selection_panels tooltip. This is due to a wrong function call in rP20046.

Test Plan

Agree the tooltip is better this way
Wonder why rP20046 changed this like this
Notice that similar code (training, construction etc.) uses this function

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/gui/session/selection_panels.js:50ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:61ESLintBear (default-case)ESLintBear (default-case)
Warningbinaries/data/mods/public/gui/session/selection_panels.js:733ESLintBear (default-case)ESLintBear (default-case)
Unit
No Unit Test Coverage
Build Status
Buildable 13180
Build 26243: Vulcan BuildJenkins
Build 26242: Vulcan Build (macOS)Jenkins
Build 26241: Vulcan Build (Windows)Jenkins
Build 26240: arc lint + arc unit

Event Timeline

bb created this revision.Mon, Sep 14, 9:01 PM
bb requested review of this revision.Mon, Sep 14, 9:10 PM
Nescio added a subscriber: Nescio.Mon, Sep 14, 9:21 PM

Correctize

The correct verb is to correct.

Nescio removed a subscriber: Nescio.Mon, Sep 14, 9:21 PM
Freagarach accepted this revision.Wed, Sep 16, 6:21 PM
Freagarach added a subscriber: Freagarach.
  • Works.
  • Correct.

Wonder why rP20046 changed this like this

Good question.

This revision is now accepted and ready to land.Wed, Sep 16, 6:21 PM

@elexis provided the hint why the line is changed: if (template.wallSet) will always be false and thus it is not necessary to go through that?