Details
- Reviewers
elexis Freagarach - Commits
- rP24437: Display header from rP21310 also for upgrades.
Agree the tooltip is better this way
Wonder why rP20046 changed this like this
Notice that similar code (training, construction etc.) uses this function
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK Severity Location Code Message Warning binaries/data/mods/public/gui/session/selection_panels.js:50 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/selection_panels.js:61 ESLintBear (default-case) ESLintBear (default-case) Warning binaries/data/mods/public/gui/session/selection_panels.js:733 ESLintBear (default-case) ESLintBear (default-case) - Unit
No Unit Test Coverage - Build Status
Buildable 13180 Build 26243: Vulcan Build Jenkins Build 26242: Vulcan Build (macOS) Jenkins Build 26241: Vulcan Build (Windows) Jenkins Build 26240: arc lint + arc unit
Event Timeline
@elexis provided the hint why the line is changed: if (template.wallSet) will always be false and thus it is not necessary to go through that?
Don't see why one will never have upgradable wallsets. Yes wallsets are never realised as global entities. But even during placement, in theory, there could be upgrades (note that I really mean upgrades, not technologies or whatever). Not that I see a direct usecase (surely it is not implemented), but I could imagine some mod wanting to up the wallset on a player command to build gates in some segments directly, or any other modification allowed by upgrades.