Page MenuHomeWildfire Games

Add basic cinematics tab to Atlas

Authored by vladislavbelov on Apr 8 2017, 4:11 AM.



Very basic tab, just for start to add new and more complex features.

The icon isn't updated on the screenshot.

Test Plan
  • Open Atlas and load any map with paths
  • Set path drawing and check that it works
  • Load any other map and check that it unset

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Apr 8 2017, 4:11 AM
Vulcan added a subscriber: Vulcan.Apr 8 2017, 4:11 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/711/
See console output for more information: http://jw:8080/job/phabricator/711/console

Icon should be changed too (patch doesn't support binaries), it should be in binaries/data/tools/atlas/toolbar/.

Fixed years/path.

Fixed EOLN.

elexis edited the summary of this revision. (Show Details)Apr 8 2017, 4:46 AM
vladislavbelov edited the summary of this revision. (Show Details)Apr 8 2017, 10:57 AM
elexis accepted this revision.Apr 9 2017, 3:51 AM

Could only find the Tooltip and Label optimization.
RIP atlasUI2.

34 ↗(On Diff #1144)

Yet another duplicate. They should be merged at some point.

43 ↗(On Diff #1144)
45 ↗(On Diff #1144)
49 ↗(On Diff #1144)
52 ↗(On Diff #1144)
55 ↗(On Diff #1144)
56 ↗(On Diff #1144)

(With the current implentation, "Draw paths" would make more sense, but the plan is to draw the selected path always, so the option would lie if it was called "Draw paths" and disabled.)

Issue (1): So the tooltip of "Draw all paths" is "Draw all paths"? Not sure how that helps :D Also would be the first atlas tooltip that does that, so it should have some kind of sentence instead.

Issue (2): Why wxEmptyString here and adding a wxStaticText before? All checkboxes in atlas besides the ones from the actor editor I could never observe have this issue, but this doesn't mean we have to repeat the mistake.

Besides adding an element which wouldn't strictly be needed, we also get this bug when selecting the checkbox, adding some selection highlight around the empty string:

Fixing (2) fixes the observation on the image.

The wxSizerFlags().Expand() flag doesn't seem to do anything, so don't see a reason to add it.

62 ↗(On Diff #1144)

(Could be enabled by default, but it's ok to have it false too, maybe less annoying if there are many paths)

67 ↗(On Diff #1144)

(Could perhaps store the previous setting, but not important)

19 ↗(On Diff #1144)

Observable.h inclusion not used

207 ↗(On Diff #1144)

(Would be nice to not have empty functions, but probably better to keep the inherited ones virtual and I guess these here will be filled in the future)

This revision is now accepted and ready to land.Apr 9 2017, 3:51 AM
elexis added inline comments.Apr 9 2017, 4:03 AM
30 ↗(On Diff #1144)

Unused, removing too

This revision was automatically updated to reflect the committed changes.