As pointed out on the forums, pressing / to select idle units only works with the / from the alphanumerical section, but not with the / from the numeric section (numpad).
Likewise, for selection groups, pressing 0 ... 9 from the numeric section is ignored.
This patch solves that by adding equivalents (for comparison, both plusses already work for zooming in.)
Details
- Reviewers
Freagarach wraitii - Commits
- rP24120: Add num pad hotkey equivalents.
Verify it works, agree this is an improvement.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | Perhaps this should be alphabetized? |
Nice addition.
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | I assume you're talking about the whole file? Yeah, but not sure it's worth the hassle ;) |
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | Lines 248 and 249 needed extra space. I did the other lines of this subsection too, for consistency; see other parts of this file for comparison. |
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | Yes and @vladislavbelov and I argue that we should not use that kind of alignment (in the future). |
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | Yes, I understand, but that would be introducing inconsistency. Just have a look at other sections, e.g. lines 185 to 210 or 286 to 321. |
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | Using the proposed changes due to file consistency. If someone decides to clean this file in the future they might take this discussion in account. |
binaries/data/config/default.cfg | ||
---|---|---|
241–251 ↗ | (On Diff #13614) | So, you see that the file already contains inconsistent lines. So my point is to move from the one consistency (with useless alignment) to another (without between-line alignment). |