un-crowdify graphics options panel
AbandonedPublic
Actions

Authored by bb on Oct 13 2020, 10:38 PM.

Details

Reviewers: None

Summary

The current graphics panel is full. Hence to implement new options (D3020, probably more), we need to move some options to another page.

Other ideas, opinions?

Test Plan

Agree on the problem.

Think about how to split the graphics options in some logical manner.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 13654
Build 27871: Vulcan Build	Jenkins
Build 27870: Vulcan Build (macOS)	Jenkins
Build 27869: Vulcan Build (Windows)	Jenkins
Build 27868: arc lint + arc unit

Event Timeline

bb created this revision.Oct 13 2020, 10:38 PM

Owners added a subscriber: Restricted Owners Package.Oct 13 2020, 10:38 PM

bb mentioned this in D3035: optionally unrandomize entity appearance.Oct 13 2020, 10:43 PM

Harbormaster completed remote builds in B13340: Diff 13630.Oct 13 2020, 10:45 PM

bb requested review of this revision.Oct 13 2020, 10:45 PM

I'd suggest to remove sky option at all, since it doesn't affect performance. Also I plan to merge the water real depth into the water refraction settings.

Other ideas, opinions?

Scrollbar? Subpages?

maybe windowed option could be moved somewhere else, e.g. general ?

Perhaps add a new tab for particles, shadows, and water effects?

In D3034#133190, @Angen wrote:

maybe windowed option could be moved somewhere else, e.g. general ?

I remember some discussion on creating the tabs, that windowed mode must be in graphics

In D3034#133196, @Nescio wrote:

Perhaps add a new tab for particles, shadows, and water effects?

Any name suggestion?

Better name suggestion are welcome

Harbormaster completed remote builds in B13622: Diff 13896.Nov 13 2020, 11:51 PM

You mean a name for a second graphics tab? I doubt the terms that spring to my mind are good:

Graphics (II)
Graphics (continued)
More graphics
Session graphics

Another thing, under “in game” there are several options that to me seem like graphics (e.g. range visualizations, diplomacy colours) and I would naively expect under the same tab as “unit silhouettes”.

How about this?

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1891/display/redirect

bb edited the summary of this revision. (Show Details)Nov 14 2020, 9:44 PM

Harbormaster completed remote builds in B13654: Diff 13926.Nov 14 2020, 9:46 PM

So I tried your patch; the good news is their is now indeed plenty of space for future additions under each tab. However, I'm not too happy you put water effects under one and shadows under another; to me they seem related. How about three graphics tabs?

general graphics: windowed mode, gui scale, and technical things I don't understand such as GLSL, postprocessing, or VSync.
aesthetics: sky, water effects, shadows, particles, smooth vision
functional graphics: unit silhouettes, range visualizations, status bars, diplomacy colours

That's just my two cents; I don't know if it makes sense for others.

By the way, I noticed the Lobby tab has just three settings (TLS encryption, chat backlog, game rating column); other multiplayer-related settings are under General (player name, network warnings, late observer joins, observer limit) and Game set-up (assign players), which makes me wonder. I don't have a perfect solution, though.