The current graphics panel is full. Hence to implement new options (D3020, probably more), we need to move some options to another page.
Other ideas, opinions?
Differential D3034
un-crowdify graphics options panel bb on Oct 13 2020, 10:38 PM. Authored by
Details
The current graphics panel is full. Hence to implement new options (D3020, probably more), we need to move some options to another page. Other ideas, opinions? Agree on the problem. Think about how to split the graphics options in some logical manner.
Diff Detail
Event TimelineComment Actions I'd suggest to remove sky option at all, since it doesn't affect performance. Also I plan to merge the water real depth into the water refraction settings. Comment Actions I remember some discussion on creating the tabs, that windowed mode must be in graphics Any name suggestion? Comment Actions You mean a name for a second graphics tab? I doubt the terms that spring to my mind are good:
Another thing, under “in game” there are several options that to me seem like graphics (e.g. range visualizations, diplomacy colours) and I would naively expect under the same tab as “unit silhouettes”. Comment Actions Successful build - Chance fights ever on the side of the prudent. builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1891/display/redirect Comment Actions So I tried your patch; the good news is their is now indeed plenty of space for future additions under each tab. However, I'm not too happy you put water effects under one and shadows under another; to me they seem related. How about three graphics tabs?
That's just my two cents; I don't know if it makes sense for others. By the way, I noticed the Lobby tab has just three settings (TLS encryption, chat backlog, game rating column); other multiplayer-related settings are under General (player name, network warnings, late observer joins, observer limit) and Game set-up (assign players), which makes me wonder. I don't have a perfect solution, though.
|