Page MenuHomeWildfire Games

Fix handling of fixed ai defined by map after rP23419
ClosedPublic

Authored by Angen on Thu, Oct 15, 8:13 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24109: Fix handling of fixed ai defined by map after rP23419
Trac Tickets
#5844
Summary

Gamesetup fails to handle cases with fixed ai rP23419.
Removing wrong 'this' and checking for 'undefined' to fix additional warnings when switching maps.

Discussed with elexis.

Test Plan

Take map from ticket and play with it in gamesetup.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen published this revision for review.Thu, Oct 15, 8:13 PM
Angen created this revision.
Angen edited the summary of this revision. (Show Details)Thu, Oct 15, 8:16 PM
Freagarach added inline comments.
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js
44 ↗(On Diff #13635)

Linter and perhaps split the condition over multiple lines for readability?

Angen updated this revision to Diff 13637.Fri, Oct 16, 5:46 PM

make linter and Freagarach happy

Angen planned changes to this revision.Sat, Oct 17, 10:12 AM
Angen updated this revision to Diff 13643.Sat, Oct 17, 12:53 PM

more linter

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Oct 24, 2:14 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Sat, Oct 24, 2:14 PM