Implicitly suggested by elexis in D1493.
Removing a cslider function, which didn't do what was in the documentation and called only once and which isn't that useful anyhow.
Adding some debug/fallbacks for invalid value combinations.
Differential D3039
Add a logarithmicly scaled slider to the options bb on Oct 16 2020, 11:40 PM. Authored by
Details
Implicitly suggested by elexis in D1493. Removing a cslider function, which didn't do what was in the documentation and called only once and which isn't that useful anyhow. Agree sliders should have this support
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1657/display/redirect Comment Actions GetSliderRatio did exactly what the comment said, you might think that the value is the misleading name though. What's a usage of the feature? It seems it makes adding steps a bit harder. Comment Actions @return ratio between the value of the slider and its actual size in the GUI value is clearly wrong, whether you call it misleading or whatelse, misleading comments are just as much telling lies about the code.
Wonders in D1493
Not harder than adding the logarithmical steps Comment Actions I suppose it means m_MaxValue - m_MinValue, but I don't mind anyway.
Does the std::log work good for all cases? It seems it needs adjustments (how the curve behaves).
Actually logarithmical steps are even messier because of precision, you can't represent some integer values in floats (in case we convert them to JS Number) |