Page MenuHomeWildfire Games

Always update preview in biome and landscape
ClosedPublic

Authored by Angen on Oct 17 2020, 2:51 PM.

Details

Summary

Introduced in rP23392.
As described in ticket, when reopening gamesetup on random map with biome, preview image is not shown correctly.
That happens because onAttributeChange in biome is called before mapChange in mapPreview, which sets default preview and because that, preview is not updated in biome back as it is in daytime.

Test Plan

(with and without diff)
open gamesetup
pick mainland
set biome
close gamesetup
open gamesetup
notice preview image

Event Timeline

Angen published this revision for review.Oct 17 2020, 2:51 PM
Angen created this revision.
Angen planned changes to this revision.Oct 19 2020, 1:46 PM
Angen updated this revision to Diff 13661.Mon, Oct 26, 8:02 PM
Angen retitled this revision from Always update preview in biome to Always update preview in biome and landscape.

add landscape as it has similar issue, notice for unknown map, if biome map would exists, it would need to be unknown_{biome} and would be
currently displayed for any type of landscape if biome would be switched, now with this diff the landscape stays selected

Owners added a subscriber: Restricted Owners Package.Mon, Oct 26, 8:02 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1673/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3325/display/redirect

Freagarach accepted this revision.Thu, Nov 5, 7:23 AM
Freagarach added a subscriber: Freagarach.
  • Works as advertised.
  • It seems other dropdowns do not have similar issues.
This revision is now accepted and ready to land.Thu, Nov 5, 7:23 AM
Freagarach removed a reviewer: Restricted Owners Package.Thu, Nov 5, 7:23 AM
This revision was landed with ongoing or failed builds.Sat, Nov 7, 4:26 PM
This revision was automatically updated to reflect the committed changes.