Introduced in rP23392.
As described in ticket, when reopening gamesetup on random map with biome, preview image is not shown correctly.
That happens because onAttributeChange in biome is called before mapChange in mapPreview, which sets default preview and because that, preview is not updated in biome back as it is in daytime.
Details
Details
- Reviewers
Freagarach - Commits
- rP24139: Always update preview in biome and landscape
- Trac Tickets
- #5785
(with and without diff)
open gamesetup
pick mainland
set biome
close gamesetup
open gamesetup
notice preview image
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13355 Build 26799: Vulcan Build Jenkins Build 26798: Vulcan Build (macOS) Jenkins Build 26797: Vulcan Build (Windows) Jenkins Build 26796: arc lint + arc unit
Event Timeline
Comment Actions
add landscape as it has similar issue, notice for unknown map, if biome map would exists, it would need to be unknown_{biome} and would be
currently displayed for any type of landscape if biome would be switched, now with this diff the landscape stays selected
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1673/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3325/display/redirect