Page MenuHomeWildfire Games

Fix vision ranges > 0 and < TERRAIN_TILE_SIZE
Needs ReviewPublic

Authored by wraitii on Nov 4 2020, 11:29 AM.

Details

Reviewers
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

As noted on D3036 and https://code.wildfiregames.com/rP24021#inline-5322

Non-zero vision ranges below TERRAIN_TILE_SIZE may not make their entity visible. This is due to some rounding in RangeManager making the game not reveal any tile.

These changes effectively reveal always at least one tile for non-0 vision ranges, which ought not change much in gameplay terms.

Test Plan

Plot outposts in FOW with a vision range of 1.

Event Timeline

wraitii created this revision.Nov 4 2020, 11:29 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3361/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1709/display/redirect

wraitii requested review of this revision.Nov 4 2020, 12:31 PM
wraitii updated this revision to Diff 13708.Nov 4 2020, 2:34 PM

Fix incremental update, which I'd missed. This fixes tests.

Vulcan added a comment.Nov 4 2020, 2:35 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3363/display/redirect

Vulcan added a comment.Nov 4 2020, 2:36 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/2810/display/redirect

Vulcan added a comment.Nov 4 2020, 2:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1711/display/redirect

Stan added a subscriber: Stan.Nov 5 2020, 1:02 AM

Tests maybe?